[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/14] efi: Avoid hard-coding the various PAT constants
- To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 14 Dec 2022 10:40:36 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+WiBrV9/WQrZ9ezepPYtvAR+hTCv7mOI9NgXXwZv0N0=; b=c6M090wJrF1OvReVJ+oeT7N8909Dpi3c5SG9so698+Bjl96CNcuHOTIt1OMXpWqWELHieP+sGSWhJ6Zm7ryKDyCGBpSw7RrlbBa6R5oeYoljvYdoFIMZNyWcniq+VfuUnKTukgLfG9aZGuH9WKJ6FZpw04ab4l/wTLFhp3o6XP76mdihZbIMnheSRi67f3LbzYENBwNTej7VF84XRxRebNFsJEk5p+bWpWPFW9dkZDEiUCbSQMd9mOaxBR5O2GapI+YlRrMcXB85stowiA3dYS48eHkmm+/1gSHTTrqz+reN9YqTcgLR6VFTIz5Ov5NGDJphrIylJtOUutdMDB5GTw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DqOEJ+T8/YNDP9OIdCeTN/KQzcDW6YBnLXN2H3b9pcJPhJ3PrLlRNqyGaV5v9wlGZXOtQ94P57iRCdmqxAqj7zuupLW99YiHox28HT6Q6pE5mSowq+eJqVpGIrVreOpi0kgNgYBT9j1JSXrwtn+FPO8lned4XxbPrMOLySaTCSVBk4x6RYVfoqx0KkiWNxDY0ultAvyTaDC9aD99BFaxlMnaiDRX2KUsrvaWxYs9y4glsLvp6z32pvZrW4HPyOLuWWdt79mt9GJJKRsTcSmvXgAYhHkno5zR8zxzz2NVop1Y1Z1RX8/mSH8OtxVk+tOygD4KH1L+fDGjKBryEXhZvQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 14 Dec 2022 09:41:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.12.2022 23:26, Demi Marie Obenour wrote:
> This makes the code much easier to understand, and avoids problems if
> Xen's PAT ever changes in the future.
>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
Nit (quoting docs/process/sending-patches.doc):
In general tags are added in chronological order. So a `Reviewed-by:` tag
should be added **after** the `Signed-off-by:` tag, as the review happened
after the patch was written.
Otherwise it looks like this patch could go in right away, if only it was
clear that it's independent of the earlier three (it looks as if it is).
Jan
|
