[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/3] x86/vmx: implement VMExit based guest Bus Lock detection
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 14 Dec 2022 10:49:23 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W9lGysKBPyAhxV7Qw/4sGAi02bOVAJ9Bp3/Xvrev0Ow=; b=kt+pFn+4H+zUbNb2sNyDmWcLOwGRH3ycsjAx7RtdSgb1k2mMpFjRPGnoBc1AIUibodHAUAz6dZFB9lMxKlD9l+N7RUavCH2NzjPQ9vZ/8Efqg8j19/0Qgi7b8l/5JMuXCA2f1m9kVRhD+5z23duyJZfytjrgFUv33aDDHKm9zwBAnzTDi+HQmcB8O6XSKcnkwwtgfeklM73n5oUoNO9kVs4ih5uyshfEbKFVqYZ29ToqWw+RUOm+Xo+jI5XEVzpotnteUIIbFawW1mdaJaC1b2Gk/UW2ySuishjfYbZgamoUZdUkezhOBs82n+/NvasbC+atH8NYed6hGq8JSP490Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lz9jt6KQ5BFRR+SfYSqYczau/n5sdbdX6MiGC20fetPsTLtBeetdg/jQefXZ37rSDf7RWpRRiugOXyWJOdzliMw8kdmrN08zj/mfiGV1yrHaeTRq9BKH7BB824CGvh0WkS1DgyXfHKbJcs8NhnrHEexFoNx77N/iBHlZVT2yHufgDPVl/2Hvi/M2nzfBNAZ7tiUW6gor9tGKEkuoRQJbqRmpFByfOA9P3m4udKWfmiC9EH3oXsvW1cZb4CTIykVoTSOlSTDZKdwikGimuGK9Qz9eWH3qxgUvkEfM7l2on5IRK98fn2+zBaXzspjFIUMxtOV9Sqfq9zcn4mdH0I7f/g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 14 Dec 2022 09:49:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.12.2022 17:31, Roger Pau Monne wrote:
> --- a/xen/arch/x86/include/asm/perfc_defn.h
> +++ b/xen/arch/x86/include/asm/perfc_defn.h
> @@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions, "exceptions", 32)
>
> #ifdef CONFIG_HVM
>
> -#define VMX_PERF_EXIT_REASON_SIZE 65
> +#define VMX_PERF_EXIT_REASON_SIZE 75
> #define VMEXIT_NPF_PERFC 143
> #define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1)
> PERFCOUNTER_ARRAY(vmexits, "vmexits",
> @@ -128,4 +128,6 @@ PERFCOUNTER(pauseloop_exits, "vmexits from Pause-Loop
> Detection")
> PERFCOUNTER(iommu_pt_shatters, "IOMMU page table shatters")
> PERFCOUNTER(iommu_pt_coalesces, "IOMMU page table coalesces")
>
> +PERFCOUNTER(buslock, "Bus Locks Detected")
> +
> /*#endif*/ /* __XEN_PERFC_DEFN_H__ */
Is there a particular reason this is added outside the / another CONFIG_HVM
conditional? (I realize the one we have only covers part of what's HVM-
specific, but it would be nice if new ones were constrained right away
(unless there's a clear expectation for them to be re-used in a more general
fashion).
Jan
|
