Re: [RFC PATCH 0/3] xen/spinlock: make recursive spinlocks a dedicated type

[Juergen Gross <jgross@xxxxxxxx>]

On 14.12.22 16:03, Daniel P. Smith wrote:
> On 9/10/22 11:49, Juergen Gross wrote:
> > Instead of being able to use normal spinlocks as recursive ones, too,
> > make recursive spinlocks a special lock type.
> >
> > This will make the spinlock structure smaller in production builds and
> > add type-safety.
> Just a little yak shaving, IMHO a spinlock is normally not expected to be 
> recursive. Thus explicitly naming a spinlock as non-recursive I find to be 
> redundant along with being expensive for typing. Whereas a recursive spinlock is 
> the special instance and should have a declarative distinction. Only codifying 
> the recursive type would significantly cut down on the size of the series and 
> still provide equal type and visual clarification.
A "normal" spinlock is non-recursive.

A recursive spinlock in Xen can be either taken recursive, or it can be taken
non-recursive, causing further recursive attempts to spin.

So the explicit non-recursive locking applies to that special treatment of
recursive spinlocks.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature