[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 04/12] x86: Add memory type constants
- To: Jan Beulich <jbeulich@xxxxxxxx>, Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 15 Dec 2022 17:17:30 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mpcp+ofV4ft5w1Nh4cgUXfkZ7kPxQhCj9kiB7nt5+r4=; b=OmkMXJkW91H7OOyzbaNoBjzpXSdm1arzqKkpE2jutzQnuODbzWpAplkElI+YCfnX+kNmQ6AZEW18zncjN941xHMS+xCnfvhlWBv6itN3txdB+oA+Vo8T/W7S/2ymB1kXf0JhUSh0QyxDo54OLzTcnci8Ki7Mt3yhYKkdS8qzoA8ccqPtKEUzg6ibQG9GUmafL1QusUh40UUHfu8eSVaFP4qo4Cs10UVaptRT689cz9i5Ihj7r5695Da/yxTkp1riDidk+4PvTdNLatH2y48IdfGKkWPFRLXT+qM2OsV0h4A7MVtJJMv8prfEISAjcJPFKKhQTbCxivoRZsNwKrJNOQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QtRGufmbZ8/wnNFnJST/D/0y1XGb/dqG22i4jI6kjDjgyCe5ndb8poNH+FMG+Npk33w/f5K3oDqa/afNpqaXv20sWmsA4i77e16LAZ1MohbEXk5UaTpZDjabkfq1z3SlexXskI7dRybgRWeLgibQnmsEpwD/2PKvWTiEyfgXaucd7HTtnYfUEDdJ0ngNrUfjoNzwA5TOXH0jIovv50+cEMYcVi6QicM7Wpkib/ChwYDODBPbJnpLB10842L9gsbevD3Eurn2Yvd2SwnkG4OqX7AmdAFGFtAVkkf+oknaFvquCtiQuL+O8dxelUOuuTQs6mBq5p2nmwtADAa9716MPg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 15 Dec 2022 17:17:46 +0000
- Ironport-data: A9a23:jTwknqx0JR7wKoopsoZ6t+eSxyrEfRIJ4+MujC+fZmUNrF6WrkVVn WoaWz2Bbq2OZmb8Ltwkbt+0phkEu5PQy9FnSQpk+yAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVkPK0T4TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVxjy NcRIxMHUhGspcfo8JO0EPc0l9t2eaEHPKtH0p1h5RfwKK56BLX8GeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDOVlVIguFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAurB99MSOLoqpaGhnXK731QMEc6UmK2qPO00EnlAMB/L FA9r39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLY7gOYLmkCUD9aadYiudM2RDolz VuAlZXiAjkHmLicU3eU7LqXhTK0JykOLGUGaDMETA0K+N3qqsc4iRenZslnOL64iJvyAz6Y6 zKXqm44jrYaj88O3o26+0zKh3SnoZ2hZg04+ATRGH6k5wVRZYi5aoju4l/ehd5cLYOxXlSH+ n8elKC2/O0ISJ2AiiGJaOEMB62yoeaINiXGhlxiFIVn8C6ik0NPZqhV6TB6YUJ2aMANfGe1Z FeJ4F0AophOIHGtcKl7JZqrDNgnxrThEtKjUe3Iat1JYd56cwrvEDxSWHN8FlvFyCAE+ZzT8 7/CGSpwJR720Zha8Qc=
- Ironport-hdrordr: A9a23:Z3uXSarPmJot7c2WT2W+MUIaV5oteYIsimQD101hICG9E/bo8f xG+c5x6faaslkssR0b9+xoW5PwIk80l6QV3WB5B97LNmSLhILPFvAB0WKI+V3d8kPFh4pg/J YlX69iCMDhSXhW5PyKhzVQyuxQpeW6zA==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZEBGWBVEvj5vBYUWFbcQB1XD67K5upD4AgACN2AA=
- Thread-topic: [PATCH v3 04/12] x86: Add memory type constants
On 15/12/2022 8:49 am, Jan Beulich wrote:
> On 15.12.2022 00:11, Demi Marie Obenour wrote:
>> --- a/xen/arch/x86/include/asm/x86-defns.h
>> +++ b/xen/arch/x86/include/asm/x86-defns.h
>> @@ -153,4 +153,15 @@
>> (1u << X86_EXC_AC) | (1u << X86_EXC_CP) | \
>> (1u << X86_EXC_VC) | (1u << X86_EXC_SX))
>>
>> +/* Memory types */
>> +#define X86_MT_UC 0x00 /* uncachable */
>> +#define X86_MT_WC 0x01 /* write-combined */
>> +#define X86_MT_RESERVED_1 0x02 /* reserved */
>> +#define X86_MT_RESERVED_2 0x03 /* reserved */
> As said, unless there's a good reason to use 1 and 2 (and not e.g.
> 0 and 1), I'd prefer these to be numbered 2 and 3 to match the
> values they expand to (and the numbering then not being as arbitrary).
TBH, I'd prefer not having them in the first place (I'll see if there's
a way to simplify the build assertions which are the only users I can
spot), but if we are going to have them then do use 2 and 3, and its
fine to abbreviate to RSVD.
~Andrew
|
