[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libxl: virtio: Fix build error for 32-bit platforms
- To: Anthony Perard <anthony.perard@xxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 15 Dec 2022 18:03:49 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4XNR+alXATVWQn8J4BXyivnxo0hcURVZHImvzjEVV2M=; b=bT9v3pF+6BFRNhAYg0VZ+ZDBUnoj7BjWeLqzHBOf4/YQnPe60AXpbqa+rxQCUJ1pcUjaRSyF4y5zRJNlaIqEhKfaFDOg6gz/1M/PlsYzoL+SwQHjb85lkpcY/81ugAwUYhXwvfemCQBNPnFhmYEIovd9x6RkzqrUP8vY6wBKntIWIxzv9/VYqQKqxXTjXII711C5JlA9GlsfhG8odtVcMj2Wtm9ZFYKjTOwBgioH+7+U+gdM1QGlV1Cz7c0g5AZBs1AilyvjKYSdHd1HxVwyFHa3EBUcTu328YM7R/TrwdqdzHP0Nw1wzjn9RZs5xnBKVWkb8q1e68IL88N2xJCGWg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K7fQt9ukCMdW8BSqg1QUhyUTlUBzRF43dTGINGW4VLt0Cr8XkyFwtpNJvBV7PnsdQOhQ88PW7WlAwb7zH8cfw4Vb/P9h/90ysQAiXkbLi6wVzSPWZez1blYggKVRNHLZAlWw3K109uhRJaq081QnnRiVy+yhLUYJC6NavT+GI5694ks3vo5rVPDKrYh3ejhK318e4u+5PM9cO4FOdZzPTpFSIuR7Tw4QsldHuf8ASeyA01SPl9OZj8kdn/ADB3YXeufkPcrLVXfBhPpaLpMDdgycYsCSM89bSZYkTUWYrYuSXmYroCe30OBcOTR/dgPg15hp2Q0BGzbIhcNnAbC4Qg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Viresh Kumar <viresh.kumar@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, "osstest-admin@xxxxxxxxxxxxxx" <osstest-admin@xxxxxxxxxxxxxx>, Vincent Guittot <vincent.guittot@xxxxxxxxxx>, "stratos-dev@xxxxxxxxxxxxxxxxxxx" <stratos-dev@xxxxxxxxxxxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Mike Holmes <mike.holmes@xxxxxxxxxx>, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 15 Dec 2022 18:05:42 +0000
- Ironport-data: A9a23:S3Foaa+1bZyQO3fSbG5rDrUDvX6TJUtcMsCJ2f8bNWPcYEJGY0x3y DBKXW6PPfrYMWTzLdF0Pd/lpk8F7cTUnNBqTQtsry48E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnP6kW5AK2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkQ9 tVBMhMyKSmTju2RwYm/RcMyuIc8eZyD0IM34hmMzBn/JNN/G9XpZfWP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWOilUvgNABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCdtKROzjqqICbFu740EcNSwyUmqHnOCYoXeeZ4lFM 0A3w397xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L8/QeDC3MECD1cbdU8nMs3QzUw0 RmOhdyBLSxitviZRGyQ8p+QrCiuIm4FIGlEYjULJSMH7MPku5oblQ/UQ5BoF6vdpt/oHTD9x RiaoS54gK8c5eYMzL6n8Evbxjugo5nPZh444B3NWWCo5R8/Y5SqD6S26F7Q4PBcaomET0Wdu 2Qsn8mY5foJS5aXm0SlW/kXFa2u/LOJPSP0hkYqG5g66y/r/3+ldJpXpjZkKy9BO8IJaXnjb UnVtA554J5VNWGtK6htbOqZENgnw6HmEpL+SvneY95KY55wXB+G+CBodQib2GWFuE0ljaE+N IrdacGtF3cXE4xjzTy/XeBb2rgurgg7xGDeA5D8yxGqypKaZXicU7BDN0GBBsg+6K6HuxnE6 NZ3OM6DyhEZW+r7CgHI9aYDIFZMKmI0ba0asORSf++HZwBgSGcoDqaLxat7ItI12aNIiu3P4 3exHFdCz0byjmHGLgPMbW1/bLToXtB0qndT0TEQAGtEEkMLOe6HhJrzvbNuJ+V2nAC/5ZaYl 8U4Rvg=
- Ironport-hdrordr: A9a23:LjHtTq85cdd9ZgvpNCduk+AiI+orL9Y04lQ7vn2ZKSY5TiVXra CTdZUgpHvJYVMqMk3I9uruBEDtex3hHP1OkOws1NWZLWrbUQKTRekP0WKL+Vbd8kbFh4xgPM lbEpSXCLfLfCVHZcSR2njFLz73quP3j5xBho3lvglQpRkBUdAG0+/gYDzraXGfQmN9dPwEPa vZ3OVrjRy6d08aa8yqb0N1JdQq97Xw5evbiQdtPW9e1DWz
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZEIm2pBLpcrFxWUiesl94gtQKma5u9s6AgAAXKACAAB2/AIAACe4AgAAIcgA=
- Thread-topic: [PATCH] libxl: virtio: Fix build error for 32-bit platforms
On 15/12/2022 5:33 pm, Anthony PERARD wrote:
> On Thu, Dec 15, 2022 at 04:58:02PM +0000, Andrew Cooper wrote:
>> A consumer of xenstore has to cope with all bases anyway. Anything that
>> doesn't is broken.
> So libxl is broken, that good to know :-).
Yes. Really, yes.
This is sufficiently basic stuff for text based APIs/ABIs that it ought
to go without saying.
> Most keys read by libxl are
> expected to be base 10, with some allowed to be in different base (as
> they're a few that uses strtoul(,,0);)
This is at least recoverable by switching to ,,0 uniformly.
That said, xenstore-paths.pandoc's attempt to describe the grammar
appears to be ambiguous.
That's the first place to fix. I'll put a ticket on gitlab because I
don't have enough cycles to do this now.
~Andrew
|
