[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN v1 1/9] xen/arm: Remove the extra assignment
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 16 Dec 2022 08:56:56 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1jaAB8Yvc2Gsh7+hS8XZAXXH6pajRoD+28gBuIpJerg=; b=i9Py730oavvTG+gRH7pfM8vS6shpA7Bn0HMAYqxLFHFjLMdgortHR2NU/XrRwLDeAQ9nR1zwD3g3Q8ktlw7PjjM6gIQp+1uyATmTAyuEPIIly+y24fHG7iT0YGGDBr45FONYnW/yFtdYlMc6FyyuRTR6ATsdkLsGtSTuOP4F2HA0GimayPezgHrXPBxWXrf0jIo3gX/uADXWRZNogQOrq8CBe0nYJpzQsq1VwutQEwKU9685OMiM/lkXuEBkN6Q2A/U6APG1eVGd7fhWz1rUQfMJF5MOAwRPySpzEygmqjX/SRl+AIcj8EWWGZ60ySMt55iXNnIn9SORl9Fr+/aHQA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mKWrPlVuD8mqu2goCG4Fzuvj0ERXEj57ri/IHTKUEAuz6XGB+AD8g91NSNJ7K9NVaDDpqcpd0s2BYTsxkuPTwqF+t7E1RSSbmG3qvSpPCZEQCBcFIcCSmtAmVgoAdEZwGXmdp6VeFVAdpE4p3u+97JCJLUZFYfkiwiN7e6dXdtbnlOUhsxhNFQDIY50dNDAtORt1nfqlMdSlayqYt21k9e3NQmxMfQ2DeDo6E5SFkP/cSeEPxMbMRoNhwGCyZB6M/zjnevN4E3jQSyk7k2F/gi1FTgmzJXo3A9ADIt/DZgumkOp+4zUzKz23tDT2YreSx7yPi+PABZ7xFQI5l0a/+g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, stefano.stabellini@xxxxxxx, julien@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, bertrand.marquis@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 16 Dec 2022 07:57:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.12.2022 20:32, Ayan Kumar Halder wrote:
> As "io_size" and "uart->io_size" are both u64, so there will be no truncation.
> Thus, one can remove the ASSERT() and extra assignment.
>
> In an earlier commit (7c1de0038895),
> "ns16550.io_size" was u32 and "io_size" was u64. Thus, the ASSERT() was needed
> to check if the values are the same.
> However, in a later commit (c9f8e0aee507),
> "ns16550.io_size" was changed to u64. Thus, the ASSERT() became redundant.
>
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
With the title improved to indicate what component is actually being touched
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
