[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] exec: Rename NEED_CPU_H -> CONFIG_TARGET
- To: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
- From: Peter Maydell <peter.maydell@xxxxxxxxxx>
- Date: Sat, 17 Dec 2022 14:17:31 +0000
- Cc: qemu-devel@xxxxxxxxxx, David Hildenbrand <david@xxxxxxxxxx>, Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Anthony Perard <anthony.perard@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, haxm-team@xxxxxxxxx, Alex Bennée <alex.bennee@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, Wenchao Wang <wenchao.wang@xxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, Roman Bolshakov <r.bolshakov@xxxxxxxxx>, qemu-arm@xxxxxxxxxx, Cameron Esfahani <dirty@xxxxxxxxx>, Kamil Rytarowski <kamil@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Reinoud Zandijk <reinoud@xxxxxxxxxx>, Yanan Wang <wangyanan55@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Sunil Muthuswamy <sunilmut@xxxxxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>
- Delivery-date: Sat, 17 Dec 2022 14:18:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, 16 Dec 2022 at 22:09, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> wrote:
>
> 'NEED_CPU_H' guard target-specific code; it is defined by meson
> altogether with the 'CONFIG_TARGET' definition. Since the latter
> name is more meaningful, directly use it.
>
> Inspired-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
This feels to me like it's overloading the meaning of CONFIG_TARGET,
which at the moment is "the string which names the header file
with target-specific config definitions". I think I'd rather
we just renamed NEED_CPU_H to something a bit clearer, like
perhaps COMPILING_PER_TARGET (better suggestions welcome).
thanks
-- PMM
|
