[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 17/18] public: misra rule 20.7 deviation on errno.h


  • To: Luca Fancellu <luca.fancellu@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 20 Dec 2022 10:51:26 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I0pwLeTur9mQ5MuOVH2MLC0uL5FB7U5JhVxqMT7ShEI=; b=Ccd/QN2qGarhh9/28fCwdLE4i+MZyLIGmN1M8nWxLlFqGAATUBx9wM3SxcDHJBkwyKgvGFqKO678aiMKgdnXGSRehvoXxJ67GwzHnYZNTMfT/8myWArgy3X1958JYIDL1msH2XzuXQk8BT3XkAO0fOOQlrbBPMmKJeKlzGkJi0HWeXs9dvnB11kcS9f8PIYbGhSFnyj2LUC3c057OhJQfPDtjYhXkaCHvhdCjuzpok9GEYcar0oAFSk+AEJiuYnxL6W43y3iksJjzkU2tN0rNaXnFuOjVN9BykSxSfeaHcEs4WJQsG0ObL8BSwau5paI/ne0geK27Sk2CUsmdl3YVg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fzLSezhJ7oM2qQegkobI9687UGgohz2ztFeC+abIFeou9gkH6WqlPbUEFffWQG7GE9vWxzayrABsy9VHer1faDSn32P469KIcG3JvVAHdQ7TliYzbNISlyODrM6Z+sl9Tut++2kJNyWjlfB/UPwDsANvyO1peJx3WFVo+d/AZy/ACgYC8s80o4KE7ngc1J8oFuQ+7pZu41S+In/xGDr3EMC+T/WCZ7hkTejbiZI6bOLGRgoP5jcrfsSDXGygF0GGBHnazJWN3uKaVXMQD7hu/hO5URwqn/tcLKJz5Gy0WxCnxTq4npGeOcnDemFQOH+oZfyJ7LPLombPrcaezugeIg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: wei.chen@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 20 Dec 2022 09:51:36 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 20.12.2022 09:50, Luca Fancellu wrote:
> Cppcheck has found a violation of rule 20.7 for the macro XEN_ERRNO,
> while the macro parameter is never used as an expression, it doesn't
> harm the code or the readability to add parenthesis, so add them.
> 
> This finding is reported also by eclair and coverity.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

But with the title adjusted - this isn't about a deviation, but actually
addressing a finding.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.