[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] xen/multiboot: add proper struct definitions to typedefs
- To: Sergey Dyasli <sergey.dyasli@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 20 Dec 2022 14:56:15 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IZ31w3lhrZVNvOvtH6RU+qBBkb2EY/fUiZ/rB9hGLVM=; b=D6qjKTVzIYv9lpftRLeL2oqiHDjUEhqfJOonmifT+TeNSZ/Y3rW2yamr74BhbJrLhm+fDI/G4vYVDwS2Q6hyseybAkYhzQooN5ZmunBKukMDLd9zwudg/ukzNHkNub8CFudb/nidIEYPEscd1uDTS3P4x8BjXl6nybkwyxSU1/5IBfHPgJbuP/gPxCGzbrSiskay4cFviIXzurg4nR3t8W1T4ZyTlHm0GdMQKmJNTa8R2AyvDaofaxWhpJcmEb5XEqZervYK4K00o/pbCb/cJAwEmya3VfCfL96sbrpszIz7cYyQGV90HG2DFRDzJsn7ip/7KyVpQaXem9CzjajjAg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DOnY/vSZEXO6JDHof8AlbcgsMmUnuS39iqWIasuLvd5Xw3wAG0BE8yz4YeGZriPAXF5dJSfj1m4yfk09W7JkKpiqFJQZKAIJU2R3UShQd6dVRRWAw/utLojZ1vDJjxlkFWxXIuQbBVWU4gFrTWymoNtVdMnD+GgXBhnW8EYoyJExAMft6/t205ugK9TQgcdL9opOtBE9PXJXZi+nI/4p7bBggA9OUUXidP2J08X+uRFdBlVu6AKIkr0wkR6uDMwHJf1diqVZhQUcmH9veFbJovUJ49HHV4k54JRPg/0rmIm6K120l0953U+WzHcpvcNpVxwZ/OgGR4p1CkbunDh7KQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 20 Dec 2022 13:56:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.12.2022 15:45, Sergey Dyasli wrote:
> This allows to use them for forward declaration in other headers.
>
> Signed-off-by: Sergey Dyasli <sergey.dyasli@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
with ...
> --- a/xen/include/xen/multiboot.h
> +++ b/xen/include/xen/multiboot.h
> @@ -46,23 +46,25 @@
> #ifndef __ASSEMBLY__
>
> /* The symbol table for a.out. */
> -typedef struct {
> +struct aout_symbol_table {
> u32 tabsize;
> u32 strsize;
> u32 addr;
> u32 reserved;
> -} aout_symbol_table_t;
> +};
> +typedef struct aout_symbol_table aout_symbol_table_t;
>
> /* The section header table for ELF. */
> -typedef struct {
> +struct elf_section_header_table{
... the missing blank added here.
I also have to admit that I would have preferred a variant with less
code churn: The typedef re-arrangement really isn't needed to fulfill
the goal pf the change.
Jan
|
