[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/22] x86/srat: vmap the pages for acpi_slit
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 20 Dec 2022 16:30:36 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fG4D2LLEzs42rqBbjJxxg9IyrJ1yESnNwywZajMxsMo=; b=KR3BvufQkrDwdKAfFbbzBWi7vmX27u5p7iTj7PEYmwjFCXlswjTX8c55k3Vj/UOLK9SP/T8173xawhV5aLo6nWjR2F1KBmhtoAslvwgQS8cUPj82urUQSHsSj9JNoS/S8kayOS8XIeanpP0jNKCYHEfF2NRSJCv7IH0MTdNTTQOnXiDu1aeN0ygH/oK8ckBs0jH4Y9PmDrNaHdpFSdszgmJQJ6L11pstF0MgJA3OOZKNw0/IdCAX5LZHoxx0M2tXReAS2SaVSIHQ63UxovmD9VML99n4CBnon4vtyyfpztNHObwuT7rMzoXYO9+JQ26rOqnyyGkqjE8mXFt2xznHGg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lmj0UGw+Zl8Bd49LEo3WqJUgcpx9eQBA4L++UPtLQXfF/rCrmOICQ4WmARhc+sAewRp7h6Xn3MMA4f5Ic7rzWp3pt2Z5lZA/JGfsCb2VK/+aEcXccLG/MkfAKlTaTKaDuhJ7hsmk11iirmzf5QZ7jtvFlWMwEyp0mUIhpSd8AnpYxOtTSde3GNixBh+K/oj0OOb9nugIpi1sFyIW/M8b82o0uhkxUNMdM2PXfZkewzogd0d5PRvweTADA8NRUStDMLSGTax7JSHqGuhxa18Qjf585wBXM8Trr2pZEGoGaXHkJUuzqZ9Pd3wowub5Frg3R9cTFWfD0dw8WyPy9S6F2w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Hongyan Xia <hongyxia@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Julien Grall <jgrall@xxxxxxxxxx>
- Delivery-date: Tue, 20 Dec 2022 15:30:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.12.2022 12:48, Julien Grall wrote:
> From: Hongyan Xia <hongyxia@xxxxxxxxxx>
>
> This avoids the assumption that boot pages are in the direct map.
>
> Signed-off-by: Hongyan Xia <hongyxia@xxxxxxxxxx>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
However, ...
> --- a/xen/arch/x86/srat.c
> +++ b/xen/arch/x86/srat.c
> @@ -139,7 +139,8 @@ void __init acpi_numa_slit_init(struct acpi_table_slit
> *slit)
> return;
> }
> mfn = alloc_boot_pages(PFN_UP(slit->header.length), 1);
> - acpi_slit = mfn_to_virt(mfn_x(mfn));
> + acpi_slit = vmap_contig_pages(mfn, PFN_UP(slit->header.length));
... with the increased use of vmap space the VA range used will need
growing. And that's perhaps better done ahead of time than late.
> + BUG_ON(!acpi_slit);
Similarly relevant for the earlier patch: It would be nice if boot
failure for optional things like NUMA data could be avoided. But I
understand this is somewhat orthogonal to this series (the more that
alloc_boot_pages() itself is also affected). Yet not entirely so,
since previously there was no mapping failure possible here.
Jan
|
