[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/8] x86/PV: drop dead paging_update_paging_modes() call during Dom0 construction
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 21 Dec 2022 18:44:33 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wF4O0w0qDP1qs4qEbhL0u+BwzXDOD7Xejbnlv4t90Ok=; b=WHHZ6lN7sJb2Ymrd35IQYjeeZjVdd9yjDwOJc7pcMQva/NUwP5FWqqpBu4/Sgh5Nc04Pdlk8RuLQhmp7Qe/wxygdMzeJWQYcqwJAYgHb3Rqev+092Vr47Wv38nLXqb1OTnbaMJ4PGafGFNjnSNJN7dnPOE1U1eEr6ix7YU2E8BjziydHtui3et1A7/yORrpu0MRbkvF06N8YRFOr1P3AonPEPXwoIyitfcMy1vIZBy2pSK5yXMkel9csnbROYy5vRHpRimppUEOvHGqoqorChc1ble5xb1DtmroUDCYnOth2hdLiohuk/jfsKajN05nRsoGzI0s/XZkBwqWSjO0YMg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KtgI2jFFWY3RzVwSVVKnjbzN8L7wlys8UR+otGVBrFSkFRcDTk6/GHSpmbaYLsOWa8SuDuhe17MHbYxPfoeHQF9vec8u3ktzL6Ce7LZTE5ot3sGmNM2mpJPUstq0gbft0exRNVGor0iclB/CdPS6sQv9rfansXsnwXG2R1KfmB+8eLz+P56RYrLPU5voq8gbgrhSC9Tnk6mphmGg3xtjzNmgWXZ0qpFDJHbw+LLM/U9qb5A5VXc2VfReU0wv5foEUyi7B5iGKH1E/ufCPkKPBtnMDSwsprj8Gb12Q+RTyUVuaLLgG12BE/WMOeqrHDdzrVJcKtQK+j3IzL13WuZdqA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>
- Delivery-date: Wed, 21 Dec 2022 18:44:42 +0000
- Ironport-data: A9a23:QACA3a2V3Kieg9josPbD5eJwkn2cJEfYwER7XKvMYLTBsI5bp2YAn TcWWTyHPveNYTSgKdx/PYvn90kOsMPVyoRqHABppC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wZkPKgQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfW39H5 eQ2KxU0NEqFm7qT6pO2TuJsr5F2RCXrFNt3VnBI6xj8VK5ja7acBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouy6KlFEZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXOqBdhLT+DknhJsqA3Jl14TFic6bkeQ/ebjpHSkQel1d FNBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9W9Vna15rqS6zSoNkA9MW4HTT8JS00C+daLnW0ophfGT9ImGqjqiNTwQGn02 2rT9HV4gKgPh8kW0an95UrAnz+nupnOSEgy+xnTWWWmqAh+YeZJerCV1LQS1t4YRK7xc7VLl CJsdxS2hAzWMaywqQ==
- Ironport-hdrordr: A9a23:Ex2PVK5y5Kvw1vzAhgPXwPzXdLJyesId70hD6qkRc3xom6mj/P xG885rsiMc5AxhOk3I5+rwQZVoMEm8yXcd2+B4UYtKOjOW3ldAA7sN0WKI+UyCJ8SRzJ856U 98GJIQNDW5ZWIRsS6xiDPULz5vq+P3lJxBZY/lvg9QcT0=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZFT/xSoTihaqcu0mTNTc3tNKJ9q54rgiA
- Thread-topic: [PATCH 5/8] x86/PV: drop dead paging_update_paging_modes() call during Dom0 construction
On 21/12/2022 1:27 pm, Jan Beulich wrote:
> The function won't ever be invoked, as paging_mode_enabled() always
> returns false here due to the immediately preceding clearing of
> d->arch.paging.mode. While compilers recognize this and eliminate the
> call, make this explicit in the source (which likely 9a28170f2da2 ["pvh
> dom0: construct_dom0 changes"] should have done right away, albeit even
> before that the call looks to have been pointless - shadow mode enabling
> has occurred later virtually forever).
>
> While there also update an adjacent partly stale comment.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
