[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops
- To: Julien Grall <julien@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Tue, 3 Jan 2023 21:22:34 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gCKpOgleSfHJ92c+Y9v38Ry7yOOQgS66T1rdtC84y1E=; b=dqTvYpEya0vaCpfIInDkOKoDSM9nyu70QTe+ZnT2NmqLgZZ7YJJaO8iYu4uXzVqFspduKQ5J8DHdrQu4+dJP8+szf1DW2K0DWxNAZzJU3Z8LWDVQooXK0K87i7TZJDenNHPAb2xiPRf/wRSTmlcWksA5UH8yxOwznSlXHrOWhB9QUsjnemg//LQ41nyxFMREc/egdUivrkcRKDxUEhjauTojbJ4gY4RN6ljxi389AyjpMI5CUOc25MoAiVU82QmEzhRsmFthjNr7EAZsCLHXKyUrtoh1ZAIZDY4vOwUmgG8DkSkZBv6F2wLZAsBlDhWsB+tRhOVBiRIK7eJ6VE+k5g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uu3S+0Pt8nu/TYtlbsPc5gfNPoQnYZJoD5rhtJxZarKOYtwHpNAxLk/KHng00ZwQBDRrBOqdfEP4iiJQEaC5D1dFxSAYHIHHHdvkZIH+bRFFtr+fawAxdKODVG1lFiJ0lmkRwtPhMiXpSZaMEHN75wuQdDWT5BY0MJvR81AQb8q9j8wLwiOFuytpzVJNT4UO+D/B9UjPRSC/69HVTJ/gP66/qc7Q4UYat8oSPnKURr796/lZOs3gptkNl4JGMO5oK9n8dOLmtJ0Y/ssG302wj+HPQXnHtYz8zh4wXH3PAjJiN/pQXt1jmQR/9sMOUZpl486YwHPvZ/lKFkG36qsYPQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 03 Jan 2023 21:23:14 +0000
- Ironport-data: A9a23:gg7TuKodUJq75S7f+drAhPfYJOleBmLSZBIvgKrLsJaIsI4StFCzt garIBnSa/3cYDehe9pxa4Ww9x4BuJOAm9VgSQdt/i1jHi0b85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5weHzyJNUfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABYicw2KhOnn/ICEWvNrp+kENPjTBpxK7xmMzRmBZRonabbqZv2QoOR+hXI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeerbIG9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzgq6Q23wfLroAVIB9JSGO4g8SptlGFXtZ9I Fw6wwEQ94FnoSRHSfG4BXVUukWsvAMYWtdWO/037keK0KW8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq11J2ZsDezMig9NnIZaGkPSg5ty8L4vIg5gxbLT9BiOK24lNv4HXf32 T/ihDc6r6Uei4gMzarTwLzcqzelp5yMVQhs4AzSBjih9lkhONXjYJG041/G6/oGNJyeUlSKo HkDnY6Z8fwKCpaO0ieKRY3hAY2U2hpMCxWE6XYHInXr327wk5J/Vei8OA1DGXo=
- Ironport-hdrordr: A9a23:3BDY4qC62fm0N8vlHemT55DYdb4zR+YMi2TDGXoBMCC9E/bo7/ xG+c5w6faaskd1ZJhNo6HjBEDEewK+yXcX2+gs1NWZLW3bUQKTRekI0WKh+V3d8kbFh4lgPM lbAs5D4R7LYWSST/yW3OB1KbkdKRC8npyVuQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZH69eYU4qCMuPJUaHOPPUV+yM+a6NKeKAgAAJu4A=
- Thread-topic: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops
On 03/01/2023 8:47 pm, Julien Grall wrote:
> Hi Andrew,
>
> On 03/01/2023 20:09, Andrew Cooper wrote:
>> diff --git a/xen/include/public/version.h b/xen/include/public/version.h
>> index c8325219f648..cf2d2ef38b54 100644
>> --- a/xen/include/public/version.h
>> +++ b/xen/include/public/version.h
>> @@ -19,12 +19,20 @@
>> /* arg == NULL; returns major:minor (16:16). */
>> #define XENVER_version 0
>> -/* arg == xen_extraversion_t. */
>> +/*
>> + * arg == xen_extraversion_t.
>> + *
>> + * This API/ABI is broken. Use XENVER_extraversion2 instead.
>
> I read this as newer tools should never try to call
> XENVER_extraversion. But I don't think this is what you intend to say,
> correct? If so, I would say that an OS should first try
> XENVER_extraversion2 and then fallback to XENVER_extraversion if it
> returns -ENOSYS.
>
> Same goes for the new hypercalls.
Right, but that's sufficiently basic that it goes without saying.
This is not a "my first introduction to writing code" tutorial.
~Andrew
|
