Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml

[Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>]

On 04/01/2023 1:36 am, Stefano Stabellini wrote:
> On Wed, 4 Jan 2023, Andrew Cooper wrote:
>> On 04/01/2023 1:15 am, Stefano Stabellini wrote:
>>> On Fri, 30 Dec 2022, Andrew Cooper wrote:
>>>
>>>> Whether to build only Xen, or everything, is a property of container,
>>>> toolchain and/or testcase.  It is not a property of XEN_TARGET_ARCH.
>>>>
>>>> Capitalise HYPERVISOR_ONLY and have it set by the 
>>>> debian-unstable-gcc-arm32-*
>>>> testcases at the point that arm32 get matched with a container that can 
>>>> only
>>>> build Xen.
>>>>
>>>> For simplicity, retain the RANDCONFIG -> HYPERVISOR_ONLY implication.
>>>>
>>>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>>> ---
>>>> CC: Doug Goldstein <cardoe@xxxxxxxxxx>
>>>> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>>>> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>>>> CC: Michal Orzel <michal.orzel@xxxxxxx>
>>>> CC: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
>>>> ---
>>>>  automation/gitlab-ci/build.yaml |  2 ++
>>>>  automation/scripts/build        | 11 ++++-------
>>>>  2 files changed, 6 insertions(+), 7 deletions(-)
>>>>
>>>> diff --git a/automation/gitlab-ci/build.yaml 
>>>> b/automation/gitlab-ci/build.yaml
>>>> index 93d9ff69a9f2..e6a9357de3ef 100644
>>>> --- a/automation/gitlab-ci/build.yaml
>>>> +++ b/automation/gitlab-ci/build.yaml
>>>> @@ -516,11 +516,13 @@ debian-unstable-gcc-arm32:
>>>>    extends: .gcc-arm32-cross-build
>>>>    variables:
>>>>      CONTAINER: debian:unstable-arm32-gcc
>>>> +    HYPERVISOR_ONLY: y
>>>>  
>>>>  debian-unstable-gcc-arm32-debug:
>>>>    extends: .gcc-arm32-cross-build-debug
>>>>    variables:
>>>>      CONTAINER: debian:unstable-arm32-gcc
>>>> +    HYPERVISOR_ONLY: y
>>> can you move the setting of HYPERVISOR_ONLY to .arm32-cross-build-tmpl ?
>> Not really - that's the point I'm trying to make in the commit message.
>>
>>> I think that makes the most sense because .arm32-cross-build-tmpl is the
>>> one setting XEN_TARGET_ARCH and also the x86_64 tag.
>> It's not about x86_64; its about the container.
>>
>> Whether we can build just Xen, or everything, solely depends on the
>> contents in debian:unstable-arm32-gcc
>>
>> If we wanted to, we could update unstable-arm32-gcc's dockerfile to
>> install the arm32 cross user libs, and drop this HYPERVISOR_ONLY
>> restriction.
> If it is a property of the container, shouldn't HYPERVISOR_ONLY be set
> every time the debian:unstable-arm32-gcc container is used? Including
> debian-unstable-gcc-arm32-randconfig and
> debian-unstable-gcc-arm32-debug-randconfig?
>
> I realize that the other 2 jobs are randconfigs so HYPERVISOR_ONLY gets
> set anyway. But if HYPERVISOR_ONLY is a property of the specific
> container, then I think it would be best to be consistent and set
> HYPERVISOR_ONLY everywhere debian:unstable-arm32-gcc is used.
>
> E.g. one day we could just randconfigs to build also the tools with a
> simple change to the build script and otherwise we would need to
> remember to also add the HYPERVISOR_ONLY tag for the other 2 jobs using
> debian:unstable-arm32-gcc.

Ok, so we want 4 HYPERVISOR_ONLY's in total, one for each instance of
CONTAINER: debian:unstable-arm32-gcc ?

~Andrew