Re: [PATCH] xen/arm: Print memory size in decimal in construct_domU

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 4 Jan 2023, Julien Grall wrote:
> Hi Stefano,
> 
> On 04/01/2023 23:41, Stefano Stabellini wrote:
> > On Mon, 2 Jan 2023, Michal Orzel wrote:
> > > Printing domain's memory size in hex without even prepending it
> > > with 0x is not very useful and can be misleading. Switch to decimal
> > > notation.
> > > 
> > > Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> > 
> > Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> 
> Was this intended for v2 rather than v1?

I didn't notice v2 was already out. I did test v2 and made sure it is
working so go ahead and pick whichever version you prefer


> > > ---
> > >   xen/arch/arm/domain_build.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > > index 829cea8de84f..7e204372368c 100644
> > > --- a/xen/arch/arm/domain_build.c
> > > +++ b/xen/arch/arm/domain_build.c
> > > @@ -3774,7 +3774,7 @@ static int __init construct_domU(struct domain *d,
> > >       if ( rc != 0 )
> > >           return rc;
> > >   -    printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n",
> > > d->max_vcpus, mem);
> > > +    printk("*** LOADING DOMU cpus=%u memory=%"PRIu64"KB ***\n",
> > > d->max_vcpus, mem);
> > >         kinfo.vpl011 = dt_property_read_bool(node, "vpl011");
> > >   
> > > -- 
> > > 2.25.1
> > > 
> 
> -- 
> Julien Grall
>