[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 5 Jan 2023 16:39:47 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KrNF1Nng7ydDEhClHRLc+rGtl/F90VRQU6sC1aXF9SQ=; b=XAON5OMb1JLYkiekyqIwvfg3w9zt6FA4TKLqSdadSYFiUIftPJUyOr+lqlnRWIWFnDrAQGQJv4JHaWn8fY//XoifJ+P5GClQpF1/C4YKdZeEJ2H3EtUx+h1enkt5493EkEE7IgMcatQaZBHmm6qZTDKbjR5wPpiDl9V9Tysi5rQTA7p9Y/r7XnwIeSEV+rbpY8mMYIMYmTUCqSFkZSsZtyMinGJ7+y+tiBXUw0EH1Tst7ujRuuB8a4QLt3S52QhU9RIUhffUx9Uufd97rzClhOmP7ca6UuNSAJ02sbZL0Hxmssz+SlFxXgeTrGq5UhodRN/jl/MNUb5byHPj5a2EPw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d/BT0ei8KvpBcUPIEQm/KsC4nKi4tAxB4RHvULPE8icLZggMIAN0Z5UHVl7SymfsDgFCuqUyaMionxcINob1Ive3GkepyZOUqycjsUN+t4O6o9kABmtxhYafIs6RluVzsxUSW9/O6jtvEzKHbOMKvLksH3X+ghjUsUvueGcCIapPMrow4B4u2wo06qvn4QFwzWnbhSFi/cBUtO2yq/drh8FAPK0SMJmSytGJw5EQ71t86CF0JuxH419RoJRWTTSsHXNgm1pIi2dlzrP7Zu7bBIYLNHAp2bSoouzPDRK5PALowwsE2SOGY+qepBoXilhpLmWT2ph9SlNcGD41jpBMcg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 05 Jan 2023 16:40:06 +0000
- Ironport-data: A9a23:ubANwaJLze2yMEjBFE+Ra5QlxSXFcZb7ZxGr2PjKsXjdYENS1GcAy 2YZXm3SPP6NamOgeYonYNyxpBgF6p/VzoJrSVBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mhA5wRjPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5uK2xTs tAYEglVa0G4rtqw8Oyads9F05FLwMnDZOvzu1lG5BSBUbMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VspTSKpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eexHirBNtJTNVU8NZTq3OJm1Y1FiEnVFjkotKTyQ2jQ/B2f hl8Fi0G6PJaGFaQZt75Uh6joX/CvQMGXNFQEOoS5wSEy66S6AGcbkAGRDNcbN0ttOctWCcnk FSOmrvBDztluqyYUnKZ+7Kdqxu9PCEUKSkJYipsZQIB4sL/qYApyBzVR9BoEbWdkdH+Xzr3x liipy84gbIRgccV1r6T8lXOgjbqrZ/MJiY3+wHWU2SN/g5/Iom/aOSA8kPH5PxNKIKYSFipv 3UencWaqucUAvmlmy2ERuEQF7iB/febNybdh1UpFJ4knxy99njmcY1O7TVWIEZyLt1CaTLve FXUuw5a+NlUJnTCUENsS4e4CsBvwa2+E93gDqzQdoAWPsE3cxKb9iZzY0LWx3rqjEUnjaA4P 9GcbNqoCnEZT69gyVJaWtsg7FPi/QhmrUu7eHwx503PPWa2DJJNdYo4DQ==
- Ironport-hdrordr: A9a23:Rj36s6x+2M8xv+E689KzKrPwKr1zdoMgy1knxilNoH1uA6qlfq WV98jzuiWatN98Yh8dcLO7Scq9qBHnlKKdiLN5Vd3OMDUO3lHYTr2KhrGD/9SPIVybysdtkY tmbqhiGJnRIDFB/KHHCdCDYrMd/OU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZIP2Dn/VS+v8CxEaK8nfj7fmLt66P1KmAgAAjsICAAAYtgIAAA8sAgAAEWIA=
- Thread-topic: [PATCH v4 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen
On 05/01/2023 4:24 pm, Oleksii wrote:
> On Thu, 2023-01-05 at 18:10 +0200, Oleksii wrote:
>> On Thu, 2023-01-05 at 15:48 +0000, Andrew Cooper wrote:
>>> On 05/01/2023 1:40 pm, Jan Beulich wrote:
>>>> On 05.01.2023 13:01, Oleksii Kurochko wrote:
>>>>> To run in debug mode should be done the following instructions:
>>>>> $ qemu-system-riscv64 -M virt -smp 1 -nographic -m 2g \
>>>>> -kernel xen/xen -s -S
>>>>> # In separate terminal:
>>>>> $ riscv64-buildroot-linux-gnu-gdb
>>>>> $ target remote :1234
>>>>> $ add-symbol-file <xen_src>/xen/xen-syms 0x80200000
>>>>> $ hb *0x80200000
>>>>> $ c # it should stop at instruction j 0x80200000 <start>
>>>> This suggests to me that Xen is meant to run at VA 0x80200000,
>>>> whereas ...
>>>>
>>>>> --- a/xen/arch/riscv/include/asm/config.h
>>>>> +++ b/xen/arch/riscv/include/asm/config.h
>>>>> @@ -1,6 +1,9 @@
>>>>> #ifndef __RISCV_CONFIG_H__
>>>>> #define __RISCV_CONFIG_H__
>>>>>
>>>>> +#include <xen/const.h>
>>>>> +#include <xen/page-size.h>
>>>>> +
>>>>> #if defined(CONFIG_RISCV_64)
>>>>> # define LONG_BYTEORDER 3
>>>>> # define ELFSIZE 64
>>>>> @@ -28,7 +31,7 @@
>>>>>
>>>>> /* Linkage for RISCV */
>>>>> #ifdef __ASSEMBLY__
>>>>> -#define ALIGN .align 2
>>>>> +#define ALIGN .align 4
>>>>>
>>>>> #define ENTRY(name) \
>>>>> .globl name; \
>>>>> @@ -36,6 +39,10 @@
>>>>> name:
>>>>> #endif
>>>>>
>>>>> +#define XEN_VIRT_START _AT(UL, 0x00200000)
>>>> ... here you specify a much lower address (and to be honest even
>>>> 0x80200000
>>>> looks pretty low to me for 64-bit, and perhaps even for 32-bit).
>>>> Could you
>>>> clarify what the plans here are? Maybe this is merely a temporary
>>>> thing,
>>>> but not called out as such?
>>> It's stale from v1 which had:
>>>
>>> #define XEN_VIRT_START 0x80200000
> Let's switch XEN_VIRT_START to 0x0000000080200000 while we don't have
> any MMU support as 0x80200000 is an address where OpenSBI will load
> binary (in our case Xen).
Ok. I've fixed that up and pushed with a tweaked commit message.
~Andrew
|
