[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 3/5] x86/mm: make code robust to future PAT changes
- To: Jan Beulich <jbeulich@xxxxxxxx>, Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 5 Jan 2023 19:58:29 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A5DcOx1HurqUvgeh7+k8zn9b8IirzaV/OriLckeh4Hk=; b=GKIcsnA0LpeKE2C2/NOUsnsrGmM9pqGYbrbljVtWTXmLsO5fIpF1uD7zLYYSkZF2W6JCqMHXeAehQXGrcRGeaCNYTlWyIP+czz+v4/K3JrbhP8I2zqK0Zc7ocJ7R5EiyLeJ+XUyuTlTRddfRbfgKhhgBDsEXOJBwjXvHm+KyDM3/Imq0Zs488JJjn3Xqe+mbZy3/IH51jV4bhFkb1rf4COMvsMuRLJvNhGopWnb4o5Dbx8JqyOfNr9MKcQcZBKNEzMgsYeBw9+DT2PaGqeq748fwXO9b6T+tuToeJ6lW0xQB0lfy47nToDD9hSxTHVJ464GPQ+3/Ujo6oKnkohuIug==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T2YyvaLvZvrl3ZruLCpIl93JC4EYd06NrS8HhlF3EVWJqTaO+e3UEWkvG1D0mSHHF5k/3XhwFIUx+E3Yjo9Q6IiJgUldKFyHbr5X23zennlAHuTY2N/th5CdbpqnQBP0+XIQd/1NRNpTWzVpGYmUcJg8pWBIFXroMb6EeoSg2G9X1WNsrXw36yYYtdWljNVtLmayRsiHp+4n17ue2HJ3X52G1LHzDEhsn+M2G+mfe5p/isJeCbNmFIEx+ke2iy+znN0tI2Zt6L7CtIzTPoWmbjI4GURhcMbqAP3aKmRj/xIrPLuQfEQoJUhjXNLTVnEfEJdoNObwLFnIjzXFUyblTw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 05 Jan 2023 19:58:38 +0000
- Ironport-data: A9a23:SUBD3K4s/PD5/zJEPIOu4AxRtM/GchMFZxGqfqrLsTDasY5as4F+v jFKCjqFbqmOYjanfNx3O4+28UJXvsfVndZkSwE/+38xHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZlPakT4QeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m/ PhIEA5dahC4gOuPnKKdWLJ9lJkgM5y+VG8fkikIITDxK98DGMqGaYOaoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooj+WF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNLT+LjqKE36LGV7nMwDwJGb1u+mqW4lmifZPAEE 2w4/iV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8ywqUA2ksTzhfaccnvss7WTwr0 FCSm9rjQzdotdW9THuH876OoDCaOC4LLHQDbysJUQsE5db4pIg5yBnIS75LD6qdntDzXzbqz FiisCk7r6Uei4gMzarT1UDKhXegq4bESiYx5x7LRSS14wVhfomnaoe0r1/B4p59wJ2xS1CAu D0OnZiY5eVXV5WVznXSHaMKAa2j4OuDPHvEm1lzEpI99jOrvXm+YYRX5zI4L0BsWioZRQLUj IbokVs5zPdu0LGCNMebv6rZ5xwW8JXd
- Ironport-hdrordr: A9a23:8LwbLqibOOMxa/Nn/EPnU5OCpXBQXiAji2hC6mlwRA09TyX5ra 2TdTogtSMc6QxhPE3I/OrrBEDuexzhHPJOj7X5Xo3SOTUO2lHYT72KhLGKq1Hd8kXFndK1vp 0QEZSWZueQMbB75/yKnTVREbwbsaW6GHbDv5ag859vJzsaFZ2J921Ce2Gm+tUdfng8OXI+fq DsgPZvln6bVlk8SN+0PXUBV/irnaywqHq3CSR2fiLO8WO1/EuV1II=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZFlVFWAiHUIB/Aka1sujnPXJ1rq6P77GAgABjzAA=
- Thread-topic: [PATCH v6 3/5] x86/mm: make code robust to future PAT changes
On 05/01/2023 2:01 pm, Jan Beulich wrote:
> On 22.12.2022 23:31, Demi Marie Obenour wrote:
>> --- a/xen/arch/x86/mm.c
>> +++ b/xen/arch/x86/mm.c
>> @@ -6352,6 +6352,11 @@ unsigned long get_upper_mfn_bound(void)
>> return min(max_mfn, 1UL << (paddr_bits - PAGE_SHIFT)) - 1;
>> }
>>
>> +
>> +/*
> Nit: Please avoid introducing double blank lines.
>
>> + * A bunch of static assertions to check that the XEN_MSR_PAT is valid
>> + * and consistent with the _PAGE_* macros, and that _PAGE_WB is zero.
> This comment is too specific for a function of ...
>
>> + */
>> static void __init __maybe_unused build_assertions(void)
> ... this name, in this file.
IMO, you really don't need to comment build_assertions(). It's a
pattern we use elsewhere, and the BUILD_BUG_ON()'s are individually
commented.
I'd just drop this hunk entirely.
~Andrew
|
