[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 00/11] x86/shadow: misc tidying


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Date: Fri, 6 Jan 2023 02:03:59 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZHeOMSQywW2NTLeKBWaSVPj0grpZVg+YVmImQT2V6Uo=; b=F4jc4xG86ipihN3KWfOT8ihmCHPSbT+Zofto1dc0KzSUOn5WhtMtUI4Ll246LVoqq5dwsLlHEy0t5jeIHA+yDjTj72NvtZZdpkroj3Ea7pdrijlpxFZ80kQ4Y7TldeALk70QdkNx5hkN8Y/ajKaFemcqwBpKIVA5KokMUex9Mx09xcRHwTQ8ohpxtACGwpTjzxYwmkaaz+5UAj1zkseOM/rScKIvf+P3NcIKaSH+ZYEiXL8DCa7I3tM7k/mI2293odg1acRcTCJ3z+Vkd12LufFHx3fMmeZwgXSXXiwQAj9ki27J0dWOnW4rBJwbAR7qCQB59Awrp0HcWWxUdixi1Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kXxZGYJTLZKwAG0Q5EA8XxDz9HOMkTmpeIgS8gbRrifJE3CfsgaOBXYuNhFmXvwxrNYGnE3CiSEI4UrBMwQEOcyWdSVcL1EYLkmJ670oE9dS94bGkZySlZaiUtdnfNJZUFg+lEaQC6eRfXos4y/zLLWTrXrvQufv4r8gf5pZRI0Fo+lg5jsouL8u5vEbmZMRa8tLUCjeCdavN9dVI5Q4+VWnDApXVSg4kIqQqbes4luxgaY7CkaNCJHt82zJacrKcM8SpZGKvvdQRXazS+z+t+PeAaTnPLIrGITX9wobhsLOFjZ2h/5GXLLxbyfXhyDH732qflND4C/cY0Uety/HXw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>
  • Delivery-date: Fri, 06 Jan 2023 02:04:08 +0000
  • Ironport-data: A9a23:Xy5d+aCDG/WEBhVW/xjiw5YqxClBgxIJ4kV8jS/XYbTApDMq1T0Fy mpMW2HXO/uNYDanfI1yPNyz8U8B6pDVxoMyQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6p4GpA4wRlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwwvswW2ZXs s0heBdWcEu8juyTw4uHc7w57igjBJGD0II3nFhFlGmcIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9exuuze7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6WzXmgCNlDfFG+3tpSvgOr23IyMh8be3KjvPKrulWuCvsKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHr7m9WX+bsLCOoluaJSkQBX8PY2kDVwRt3jX4iIQ6jxaKQtM9Fqew14XxAWupm 2/MqzUijbIOi8JNz7+84V3MnzOroN7OUxIx4QLUGGmi62uVebKYWmBh0nCDhd4oEWpTZgPpU KQs8yRG0N0zMA==
  • Ironport-hdrordr: A9a23:Y2b5N6pNurjA8vGv/2n3SOEaV5oaeYIsimQD101hICG9E/bo9f xG+c5xvyMc5wx9ZJheo6HlBEDtex/hHOdOkO4s1NSZLWrbUQmTTb2KhLGKqwEIfReQygc378 ddmsZFZuEZ8jBB/KPHCQODYrAdKHDuytHQuQ7W9QYUcT1X
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHZIR54p1+0rBg1XUyPGnzUS/cXvK6QpAqA
  • Thread-topic: [PATCH 00/11] x86/shadow: misc tidying

On 05/01/2023 3:57 pm, Jan Beulich wrote:
> ... or so I hope. The main observation was that we still have both
> hash_vcpu_for_each() and hash_domain_for_each(), where the latter was

foreach

> introduced in 2014/15 to replace the former. Only some eight years
> later we can now complete this conversion. Everything else addresses
> other things noticed along the road.

Wow, it has been a long time.  That was the start of the "make Xen not
fall over NULL pointers if the toolstack issues some hypercalls out of
order", a task that is still ongoing...

>
> 01: replace sh_reset_l3_up_pointers()
> 02: convert sh_audit_flags()'es 1st parameter to domain
> 03: drop hash_vcpu_foreach()
> 04: rename hash_domain_foreach()
> 05: move bogus HVM checks in sh_pagetable_dying()
> 06: drop a few uses of mfn_valid()
> 07: L2H shadow type is PV32-only
> 08: reduce effort of hash calculation
> 09: simplify conditionals in sh_{get,put}_ref()
> 10: correct shadow type bounds checks
> 11: sh_remove_all_mappings() is HVM-only

Everything without code queries, Acked-by: Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.