Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE

[Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>]

On 6/1/23 12:57, Bernhard Beschow wrote:
> Am 4. Januar 2023 15:35:33 UTC schrieb "Philippe Mathieu-Daudé" 
> <philmd@xxxxxxxxxx>:
> > +Markus/Thomas
> >
> > On 4/1/23 15:44, Bernhard Beschow wrote:
> > > During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of
> > > TYPE_PIIX3_DEVICE. Remove this redundancy.
> > >
> > > Signed-off-by: Bernhard Beschow <shentey@xxxxxxxxx>
> > > ---
> > >    hw/i386/pc_piix.c             |  4 +---
> > >    hw/isa/piix.c                 | 20 --------------------
> > >    include/hw/southbridge/piix.h |  1 -
> > >    3 files changed, 1 insertion(+), 24 deletions(-)

> > >    -static void piix3_xen_class_init(ObjectClass *klass, void *data)
> > > -{
> > > -    DeviceClass *dc = DEVICE_CLASS(klass);
> > > -    PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
> > > -
> > > -    k->realize = piix3_realize;
> > > -    /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */
> > > -    k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0;
> > > -    dc->vmsd = &vmstate_piix3;
> > IIUC, since this device is user-creatable, we can't simply remove it
> > without going thru the deprecation process.
> AFAICS this device is actually not user-creatable since dc->user_creatable is 
> set to false once in the base class. I think it is safe to remove the Xen class 
> unless there are ABI issues.
Great news!