[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 3/8] xen/riscv: introduce stack stuff
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 6 Jan 2023 15:15:46 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PwcgD9BxLJS1uqkaTVy7HqdrmgombZtt5wnEh7+I6Dc=; b=cRzaDVcCXY6sLwGCunnPAZ28lg6XvU3hweHGkmOmRx5Ckx4UYkqV4RsMKwu36d2xMCRmqrK9YqEQcgR6XF+OWrsCq4itBpnO9qWifKOwtZMlhy5fPYUjykEUy9oA/FkkDklwFi5WyiZrsUHLLkIeYySNdYu0YHBz/KuYPqIW7tpw9F0tWLAPfIAVOxcZ7HPSn7URzdfMb68RkA2MkogJZtPAXfxcy5DzvlKqS5JbQnxGZd/NVWdYfnbCRyHRll45wEYIYGEauAz7eJTZfd5dQQapEDizvwgGM3rEYgjZW0jf6DTPG88sFWqyworl8i8ukPbRlxIedTlGWjQNH8hn8g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ErnpGFYYvUKQPCgH7ZKSSwUdvqUNMkGtZqaxORVlKUJO94OC/cHO738bRKuFrouO2vIuOiCzlWfaLSE7cRTRVLp39IAZjaJTizWm8KSlDx0Tmdk6QyS6uxzaR7/BTLSELQUXBj/JswI4taDZD8Oy7IrEqUg+kwUTPKteZq5FI3X6974TeQqfdNAKas38YPGIl6E+NttZDddEFAw4ZeEsIoZiDqkrK4PDcgTdg8JVZOaQZd2Rj4lpp17j1oydf/kFlXlCSX48kSQRteV3/dnNUMbI8essHDFw++fyM2ca8mAzqlSSOVxAsb97IQzmgPLYLpY+jvqFbuo5BB9312mTxw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 06 Jan 2023 14:15:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.01.2023 14:14, Oleksii Kurochko wrote:
> --- a/xen/arch/riscv/riscv64/head.S
> +++ b/xen/arch/riscv/riscv64/head.S
> @@ -1,4 +1,10 @@
> .section .text.header, "ax", %progbits
>
> ENTRY(start)
> - j start
> + la sp, cpu0_boot_stack
> + li t0, PAGE_SIZE
> + add sp, sp, t0
> +
> +_start_hang:
> + wfi
> + j _start_hang
Nit: I think it would be nice if in a new port assembly code used
consistent padding between insn mnemonic and operand(s).
Jan
|
