[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru
- To: Chuck Zmudzinski <brchuckz@xxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Fri, 6 Jan 2023 14:42:35 +0000
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <qemu-devel@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 06 Jan 2023 14:43:00 +0000
- Ironport-data: A9a23:VJswE6jTu9xi3QxlCHxLmkylX1610BAKZh0ujC45NGQN5FlHY01je htvXmCAb66KNmChf41/aYzk8E0G7Zbcn9VqHApvrX89Fykb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6sT5QeAzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQaOmsffgiMo9uo44K3dMN8t58/KvPCadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglH2dSFYr1SE47I6+WHJwCR60aT3McqTcduPLSlQthfA9 zyYoT2jav0cHMSSxAHfq3utv8beu3nnVdMLF5yz+OE/1TV/wURMUUZLBDNXu8KRh0KjUshTL GQU8yAtqrMuskqmUrHVRRyzoHeeslgcVtxcHvch7welzqvS6hyeQG8eQVZpbcc6nNU7STwjy hmCmNaBLSxitviZRGyQ8p+QrCiuIm4FIGkafygGQAAZpd75r+kbixvVRdtnVqetgNDxEzjtx hiFqSE/g/MYistj/7y2+E2Cjz+yq5zhSAkz6QPKGGW/4WtRbpSuZ5Gj6krz5PFEao2eSzGpp 2MYksKT6OQPC5CllyGXRugJWraz6J6tKDfbh0xuGZgJ7Tmh+3e/O4tX5VlWPE50Nu4UdDmvZ 1Xc0T69/7cKYiHsN/UuJdvsVYJ6lsAMCOgJSNjWfIFccoB+UDaZ3xFiW2SA7jvxlnIFxPRX1 YigTe6gCnMTCKJCxTWwRvsA3bJD+h3S1V8/VrigkU35jOP2iGq9DO5cbQDQNrxRALas+l29z jpJCyedJ/yzusXaazKfz4McJEtiwZMTVcGv8Jw/mgJuz2Nb9IAd5x35m+hJl29Nxf49egL0E paVBCdlJKLX3yGvFOlzQikLhEnTdZh+t2knGicnIEyl3XMuCa72svhFJsdsIOl2qL0ypRKRc xXjU5/QahioYm2ekwnxkLGn9NAyHPhVrVjm09WZjMgXIMc7Gl2hFi7MdQrz7igeZheKWT8Fi +T4jGvzGMNTLzmO+e6KMJpDOXvt5ylC8A+zNmOUSuRulLLEqtAycXKp1qVnf6nh63zrn1On6 upfOj9AzcGlnmP/2IChaXysx2txL9ZDIw==
- Ironport-hdrordr: A9a23:/alh+6ClgOS3hhjlHemd55DYdb4zR+YMi2TDgXoBLCC9E/bo7P xG+c5wuCMc5wxhP03I9erwQZVoIkm8yXcW2/h0AV7KZmCP01dASrsSjrcK7AeQeREWndQts5 uIHZIOcOEYzmIUsS852mWF+hobruVvOZrJudvj
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Jan 06, 2023 at 09:10:55AM -0500, Chuck Zmudzinski wrote:
> Well, our messages almost collided! I just proposed a v7 that adds
> a check to prevent the extra processing for cases when machine is
> not xenfv and the slot does not need to be cleared because it was
> never reserved. The proposed v7 would not change the behavior of the
> patch at all but it would avoid some unnecessary processing. Do you
> want me to submit that v7?
Well, preventing an simple assignment and a message from getting logged
isn't going to get us far. On the other end, the message "using slot 2"
when we don't even if slot 2 is actually going to be used could be
confusing, so I guess preventing that message from been logged could be
useful indeed.
So your proposed v7 would be fine.
Cheers,
--
Anthony PERARD
|
