[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 20/22] xen/arm64: mm: Use per-pCPU page-tables
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 6 Jan 2023 14:54:56 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mHgBBafFbsjAzJLPSAzRUNa0KLBtz3G/c8cHAzWDPrc=; b=P2+juIv/+mzTcf1Rmd6Nval0zVoEGtfRUyyVFjkFSFcDGgsRrSovOdI47pnyJoiwCXixzo56verUBAOy35IAVWb2kbyT0K0qTN4uVaHDGNfnOvTdyUZTRpGNaRMWzMG598pWrjJM2QAqhvPQstohE8MHfzyK8jIZIAHlvhWIUBC6PedUn/EbrfH09P3LKnH7GHy1fKzOf04ZbvFdc6uLsHm89LTzVd3CFX4kMoTok65j+HvDesUmlFu8ag5JIUf25FXfIHOh3A3dTA/npYaHkH1Mt5fl5oTQ9y/pqTOchJLPsC7V/6PcQl62yYgLvUUqSg0PNgnfdAppTvLCde8sNg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AKsN0lqP4/0psYiA8OjdxuQR1XPZckPpQ8uQQst73D0cdGqVeEU3E7jONU85IXszsvCtyYCxKbupQM9FNgXaZGrCeBxsPZuVmeXyhrpfxRIOiPqXqhip/x522/bsKHJZ/0U+zQ0fyBv8WLI0MjdD7nXMgo4x3VRx2YqHuD+0pfDechbkU78nvViW6jTsf+CD+0I1qS3va45mJpuYSuZJncEOL23orR1VaJZ18yq5QaXJxfZbmsuaUrgRQ/yydCchtkG/xcawzsDRG87V7OArN+UyU+MlFWwCFLzvOGHO3T5RtRQRmXbYBV8LRNYRkjwUhOA9AIwVxGaL2ZM49yIE+Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 06 Jan 2023 14:55:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZEUh12RKmuw645EafAVdnfeFYOK6RkuHg
- Thread-topic: [PATCH 20/22] xen/arm64: mm: Use per-pCPU page-tables
Hi Julien,
> -----Original Message-----
> Subject: [PATCH 20/22] xen/arm64: mm: Use per-pCPU page-tables
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> At the moment, on Arm64, every pCPU are sharing the same page-tables.
Nit: s/every pCPU are/ every pCPU is/
>
> /*
> diff --git a/xen/arch/arm/include/asm/domain_page.h
> b/xen/arch/arm/include/asm/domain_page.h
> new file mode 100644
> index 000000000000..e9f52685e2ec
> --- /dev/null
> +++ b/xen/arch/arm/include/asm/domain_page.h
> @@ -0,0 +1,13 @@
> +#ifndef __ASM_ARM_DOMAIN_PAGE_H__
> +#define __ASM_ARM_DOMAIN_PAGE_H__
> +
> +#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE
> +bool init_domheap_mappings(unsigned int cpu);
I wonder if we can make this function "__init" as IIRC this function is only
used at Xen boot time, but since the original init_domheap_mappings()
is not "__init" anyway so this is not a strong argument.
> +#else
> +static inline bool init_domheap_mappings(unsigned int cpu)
(and also here)
Either you agree with above "__init" comment or not:
Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
