[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 22/22] xen/arm64: Allow the admin to enable/disable the directmap
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 6 Jan 2023 14:55:10 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pvb4D82JzYha9OwUYmFkfhpda4iWTVoaQQUM1CakWko=; b=KtDvqMcies27SHY2M+lKqeUZmXejBtrtUSvlKnzhkE1LwRig6HXVquxeLavBaOYVYSvldfRsSqz6Wv7xuNwBQNPlG4rjC2bPUlZAWYuZUWKMBptwvaHNPUjoihM2piFRCChfcFTHRZwseuE/0S9HHDSOGCIwD6OtzA65b6AFRZlO00fxJOeOwQBpbxgkYSoYUJTZfAQYtS3boSGALi3k87unzefNr42dxKm9Xt8aN7QPBH5Lntr6jPZJYDmZG3cCtaDs/lLgl2v78F6d3BTPcNE/cXABOy55XoJ5G/ddVHzO/GS65gC/Va9WD//Fd1cKoaj8sM5Kuw4clB4dsB3Djw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OzVdum+7CSjxhKe2Z2G+T37IUNFKTKFriY2iJoxOz6cbxwyHjmkhfJx5d3mfHYlKUxtCx5pkki0/1asrTIXBELbkgN86LAWj9cQnikWlvrfC3Sm3bbYTqzN/qiKiuZB/7THpYZVAa/AhqzQFO+439Z8HCp/o/kyoHLFATvcq+/bOtFBaApnVjw6px75IZjBhyHOzbzgS7sPg0jq7Qld4bzByPsyOeIig4nAe5hUe4kw1gpWuUOeOdjHQd4wy9z9Hsu5SQdVnP/h2n2WwrUe/EKGA8l7Raku/2g++7Brz4BviGb2Lc1+wDOvqPcNQN8bDyvRw9mGh92BOuqHVMseC1A==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 06 Jan 2023 14:55:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZEUh1e0APpjxFfUWN/NZXS3PZ8q6RmKBQ
- Thread-topic: [PATCH 22/22] xen/arm64: Allow the admin to enable/disable the directmap
Hi Julien,
> -----Original Message-----
> Subject: [PATCH 22/22] xen/arm64: Allow the admin to enable/disable the
> directmap
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Implement the same command line option as x86 to enable/disable the
> directmap. By default this is kept enabled.
>
> Also modify setup_directmap_mappings() to populate the L0 entries
> related to the directmap area.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
>
> ----
> This patch is in an RFC state we need to decide what to do for arm32.
>
> Also, this is moving code that was introduced in this series. So
> this will need to be fix in the next version (assuming Arm64 will
> be ready).
>
> This was sent early as PoC to enable secret-free hypervisor
> on Arm64.
> ---
> @@ -606,16 +613,27 @@ void __init setup_directmap_mappings(unsigned
> long base_mfn,
> directmap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE;
> }
> #else /* CONFIG_ARM_64 */
> -/* Map the region in the directmap area. */
> +/*
> + * This either populate a valid fdirect map, or allocates empty L1 tables
I guess this is a typo: s/fdirect/direct/ ?
Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
