[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/11] x86/shadow: replace sh_reset_l3_up_pointers()
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 9 Jan 2023 09:35:42 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xcNPlZgRTW3qxOdChmYcm+u8tTQMcr/GLd+WO/WmLE4=; b=RGvVYL38Gylr4KLhV3ztUWtSPI0J98WiR8IIDP480w1gni/dcTyqxq09XrG+ZkntCv8q39KlcLpjGzHUsxIXgybD3FYg/lU1Fw7XfyMR91E55UTBxjphCMhlPoKDTympWNDapfTiApzA7fuKPeb5afcLRHv4sAABSiFWwTm55RfNHj67ObSCOhBV/EZ8pAlJiNj/bAerpX2XGCxWV0PEBvuy3YeF/rVYS/gRHdHLZwy1oyyUpxrS/MiA0XO50AmyS/Vq1A98lKe7tsdujNDPiMb2KUqbhJ3GcQ2Tq/4owT1rL/CTk+lD8dzh4HWFdJri6tPuAUk5xa/PRrlylpdieA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XKzkWlUEBDcGqylYuWi/2iZl0ad3xGYBVOo2l62UWVFAiP1jTWP2FRv1b1m+1CcW2EbkdEUflZY/VQf7GizW3UIxD7VKedWUvcJvTwkuR8H7I0ZrauD4Qzpuw4M9Vzmz/U0GczMSKn5t0ikVcvyHQ8AQuUIHLWXbirCY6I8vwCWFNtRGxcYAgQkkZ8cfdAqWE8t/0YksClSFls5cTfY/1CX0RVkm52rgDJ8sErvr6yb5Fl0JtvZQdgx+a3fVAAMPuDPDTD9hAmogevz3FXWE+5zTD7Ih4aCIErdhbtUtXc5kX7ANJw6rrW+JsgHNUmfkSbX+vTx5jlEdANTTjnGI7w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 09 Jan 2023 08:35:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.01.2023 01:55, Andrew Cooper wrote:
> On 05/01/2023 3:59 pm, Jan Beulich wrote:
>> Rather than doing a separate hash walk (and then even using the vCPU
>> variant, which is to go away), do the up-pointer-clearing right in
>> sh_unpin(), as an alternative to the (now further limited) enlisting on
>> a "free floating" list fragment. This utilizes the fact that such list
>> fragments are traversed only for multi-page shadows (in shadow_free()).
>> Furthermore sh_terminate_list() is a safe guard only anyway, which isn't
>> in use in the common case (it actually does anything only for BIGMEM
>> configurations).
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Thanks.
> I think. The reasoning seems plausible, but it would probably benefit
> from someone else double checking.
Okay, I'll wait some to see whether Tim or George may voice a view. Perhaps
until the end of this week, committing early next week if no contrary
indications appear. The "good" thing here is that all modern 64-bit guests
undergo this transition aiui, so the code is / will be properly exercised.
Jan
|
