Re: [PATCH v1 8/8] automation: add RISC-V smoke test

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Fri, 2023-01-06 at 15:05 +0000, Andrew Cooper wrote:
> On 06/01/2023 1:14 pm, Oleksii Kurochko wrote:
> > Add check if there is a message 'Hello from C env' presents
> > in log file to be sure that stack is set and C part of early printk
> > is working.
> > 
> > Also qemu-system-riscv was added to riscv64.dockerfile as it is
> > required for RISC-V smoke test.
> > 
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > ---
> >  automation/build/archlinux/riscv64.dockerfile |  3 ++-
> >  automation/scripts/qemu-smoke-riscv64.sh      | 20
> > +++++++++++++++++++
> >  2 files changed, 22 insertions(+), 1 deletion(-)
> >  create mode 100755 automation/scripts/qemu-smoke-riscv64.sh
> 
> Looking through the entire series, aren't we missing a hunk to
> test.yml
> to wire up the smoke test?
> 
Missed that. Will update test.yml in the next patch series.
> It wants to live in this patch along with the introduction of
> qemu-smoke-riscv64.sh
> 
> However, the modification to the dockerfile want breaking out and
> submitted separately.  It will involve rebuilding and redeploying the
> container, which is a) fine to do separately, and b) a necessary
> prerequisite for anyone else to take this series and test it.
> 
I am going to send a patch with the dockerfle modification today.
Thanks.

> ~Andrew
~ Oleksii