[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/17] xen/arm: use NR_MEM_BANKS to override default NR_NODE_MEMBLKS
- To: Wei Chen <wei.chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 10 Jan 2023 10:59:43 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oJgTaLj0E3C8Gvf+1diGzcKyvH9w8oRVYT/kyGbpfTc=; b=S8UED2Ap7qGpA8x9aL7yQvdPARETgEYEBGXsQ5OOKDdp9GcwMcHyJ85VtQZjcqumDjAnJ1Mi57C9Z1a8NakOYjMBn01VPWZ5zsaOJGLR1POXgwdUj6fjVlgMz9OEIHzWUE/gJWzbCLsHDQNjVopnkblunHie5vBMVmFg1ElSKHXipokfnytccdUEbajqEM0KTcqDhPRqqpHYt6Lwm0t/pWJUxak3DFcKfF3CPoNnCqPO5OStyaPvHapmlEctoWfQQqFfKBii429vaEcsaskx1IW+hEtYC/JU3BasLCvv4kd627zmZgwriv52ju9FQUvwemZ9LhebyfBGNkOKo5k1Tg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bxj/6fZwYIWRMudwi7gdaPMN2iZyfxm/Rq3QNmNZqcQ3sa+MN/PwQkHd/oOyJhyxPQTwkOJTdSbjPKF16Prr5CKRmEUML9dXEvc4PcFaIlSGsP0O2J9Ge/kO8RoFDi8hE3htlmMetgJjwfVIc4j5BcM2SIVlW3ajKlBJUFZu6W/JW+of12tMwoIacQhc9xENqjgCb5eomG8eKdDdA55rl/ZcpopVLiBFQbRxarlv0gqzAsw8hOHx6P+4n+PJ6jENeD9IUVPb+1YIB65pzMMkzrdilJwBljLOwTBZkYhNoDmaNcMMAmqXAO1WSFnhjhRYPPmCvZzOAQ3OBgp1uopYtw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: nd@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 10 Jan 2023 09:59:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.01.2023 09:49, Wei Chen wrote:
> --- a/xen/arch/arm/include/asm/numa.h
> +++ b/xen/arch/arm/include/asm/numa.h
> @@ -3,9 +3,26 @@
>
> #include <xen/mm.h>
>
> +#include <asm/setup.h>
> +
> typedef u8 nodeid_t;
>
> -#ifndef CONFIG_NUMA
> +#ifdef CONFIG_NUMA
> +
> +/*
> + * It is very likely that if you have more than 64 nodes, you may
> + * need a lot more than 2 regions per node. So, for Arm, we would
> + * just define NR_NODE_MEMBLKS as an alias to NR_MEM_BANKS.
> + * And in the future NR_MEM_BANKS will be bumped for new platforms,
> + * but for now leave NR_MEM_BANKS as it is on Arm. This avoid to
> + * have different way to define the value based NUMA vs non-NUMA.
> + *
> + * Further discussions can be found here:
> + * https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg02322.html
> + */
> +#define NR_NODE_MEMBLKS NR_MEM_BANKS
But isn't NR_MEM_BANKS a system-wide setting, which doesn't really
make sense to use as a per-node one? IOW aren't you now allowing
NR_MEM_BANKS regions on each node, which taken together will be
much more than NR_MEM_BANKS that you can deal with on the whole
system?
Jan
|
