[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx
- To: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
- From: BALATON Zoltan <balaton@xxxxxxxxxx>
- Date: Tue, 10 Jan 2023 23:01:52 +0100 (CET)
- Cc: qemu-devel@xxxxxxxxxx, Peter Maydell <peter.maydell@xxxxxxxxxx>, qemu-block@xxxxxxxxxx, qemu-arm@xxxxxxxxxx, qemu-ppc@xxxxxxxxxx, Richard Henderson <richard.henderson@xxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, ale@xxxxxx, qemu-riscv@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Thomas Huth <thuth@xxxxxxxxxx>
- Delivery-date: Tue, 10 Jan 2023 22:04:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, 10 Jan 2023, Philippe Mathieu-Daudé wrote:
The 'hwaddr' type is defined in "exec/hwaddr.h" as:
hwaddr is the type of a physical address
(its size can be different from 'target_ulong').
All definitions use the 'HWADDR_' prefix, except TARGET_FMT_plx:
$ fgrep define include/exec/hwaddr.h
#define HWADDR_H
#define HWADDR_BITS 64
#define HWADDR_MAX UINT64_MAX
#define TARGET_FMT_plx "%016" PRIx64
^^^^^^
#define HWADDR_PRId PRId64
#define HWADDR_PRIi PRIi64
#define HWADDR_PRIo PRIo64
#define HWADDR_PRIu PRIu64
#define HWADDR_PRIx PRIx64
Why are there both TARGET_FMT_plx and HWADDR_PRIx? Why not just use
HWADDR_PRIx instead?
Regards,
BALATON Zoltan
|