[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: Remove the arch specific header init.h
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 11 Jan 2023 12:14:25 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0MvJYukd5RpqeKbJG/1RE6/DG6w+HNio7w46iNbYORc=; b=WTi5ZtlDZzjX1/HTXU/yDLDyCC6Jez9xh0+7KJ4VoCIjT9AkzzKXg9IguJbTF6Vij+K4a31j1YDTXjV4tKbwTzPhXm+0YesaQL2G2EodQloTf+bvkAxLHD3VN94EidaH/yXMTNRJVJALETgxPosbmaxikD0ZkCXbnhaaK/eTdRBb2Q/124tb+u5HG7dgXJ2Ep2F7hF+/9QPNGUSMFF8noSrCNmHAaRkNEIQZSE14/+81Sl4nWSolAEhGQp7isOK9WaAG5Lzfhn9VStV8HjtRKdHRvczEnx0rfHSJeMo+QlM1ES5clVdrBdjMgl7JxPFeYRlCe5XlR+O5YcceDfNWpQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wb4an7EHPilKYVUEzdozvgngNC7ureDTzteTt0XtSdgFemxw54FUlZYs1MjUuT3rDBMAaZSlONQirGu2geeB79NPH6W0xChxTTHLm+pXEC4S7Oizo1aLh5iRwrxC7EP9KZgLwUtspkZ2pFPIFx2/+ABO4Gx5qK3zqrBlTvSH0UaPbt4XVn8ivmtINEhQNz+8YIKJvvPWp/ldhT+LRbIbWCfjsGla2bZVU7Q9dVjZaupkUkcG+zsSLmQcOMKZPQCCwMsAfviAFTYYDyI3kl59JF8D0k8nZ7slcxSGYXEhiEoObMNoo0b+Do65pJaNKPoDb7O92NEyXAv8a5j8yV2Zww==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Wed, 11 Jan 2023 12:14:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZJbIaKE9+sa25KkC1qw/e7vlCUK6ZIQwA
- Thread-topic: [PATCH] xen: Remove the arch specific header init.h
> On 11 Jan 2023, at 11:44, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Both x86 and (soon) RISC-V version of init.h are empty. On Arm, it contains
> a structure that should not be used by any common code.
>
> The structure init_info is used to store information to setup the CPU
> currently being brought-up. setup.h seems to be more suitable even though
> the header is getting quite crowded.
>
> Looking through the history, <asm/init.h> was introduced at the same
> time as the ia64 port because for some reasons most of the macros
> where duplicated. This was changed in 72c07f413879 and I don't
> foresee any reason to require arch specific definition for init.h
> in the near future.
>
> Therefore remove asm/init.h for both x86 and arm (the only definition
> is moved in setup.h). With that RISC-V will not need to introduce
> an empty header.
>
> Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
>
Hi Julien,
The arm part looks good to me, I’ve also built x86, arm32 and arm64 and
no problems found.
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
