[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/6] xen/riscv: introduce asm/types.h header file
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- Date: Wed, 11 Jan 2023 16:50:13 +0200
- Cc: Julien Grall <julien@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Oleksii <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Wed, 11 Jan 2023 14:50:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 1/11/23 15:17, Jan Beulich wrote:
On 11.01.2023 13:30, Xenia Ragiadakou wrote:
Could you please help me understand also
why __signed__ keyword is required when declaring __{u,s}<N>?
I mean why __{u,s}<N> cannot be declared using the signed type
specifier, just like {u,s}<N>?
I'm afraid I can't, as this looks to have been (blindly?) imported
from Linux very, very long ago. Having put time in going through
our own history, I'm afraid I don't want to go further and see
whether I could spot the reason for you by going through Linux'es.
Sorry, I was not aiming to drag you (or anyone) into spotting why Linux
uses __signed__ when declaring __s<N>. AfAIU these types are exported
and used in userspace and maybe the reason is to support building with
pre-standard C compilers.
I am just wondering why Xen, that is compiled with std=c99, uses
__signed__. If there is no reason, I think this difference between the
declarations of __{u,s}<N> and {u,s}<N> is misleading and confusing (to
me at least).
--
Xenia
|