Re: [PATCH v2 07/19] tools/xenstore: introduce dummy nodes for special watch paths

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 11/01/2023 06:41, Juergen Gross wrote:
> On 20.12.22 20:39, Julien Grall wrote:
> > > +static void fire_special_watches(const char *name)
> > > +{
> > > +    void *ctx = talloc_new(NULL);
> > > +    struct node *node;
> > > +
> > > +    if (!ctx)
> > > +        return;
> > > +
> > > +    node = read_node(NULL, ctx, name);
> > > +
> > > +    if (node)
> > > +        fire_watches(NULL, ctx, name, node, true, NULL);
> > NIT: I would consider to log an error (maybe only once) if 'node' is 
> > NULL. The purpose is to help debugging Xenstored.
> I think we can log it always, as this is really a bad problem.
That works for me. If it is always logged, then I guess this would need 
to be a syslog message as well.
Cheers,

--
Julien Grall