[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/8] x86/acpi: separate AMD-Vi and VT-d specific functions
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 12 Jan 2023 13:40:42 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DWGd4cOKC7AWrDXtTKfwpBoWoOay9JCrx3MBYUZ5DJg=; b=UvaqhYY9oGmDiNKzq0qXCpD49EqRH3nnzZ7i54nm8gSZdloEO4/TLqoOIO9xUULYlCli7VFg4TYyg6P0N8OypIqxMYkHTQsjwWhl2wnVkQKoGf5K9wCFy3cFFd2DxJoNJnzniYLNod4Hm3rI7PlY8RppTIJMhsYwfPRLGMiNHdH73Jh0Ai3dCDRQ2SYgDaYrDYmij6YtPyCU+Dy2/gyT90cId1zorHUQ0li195YrCZqUicemGL6znMNyHQxv0NdIn/nn0sS7hSweBA/rhojdWrx2GfjO1Dt/JrNKwQ/gqzCv6NprxCBxwZwH6cjr9dXUGtUs/cMmk+L61gWi4x01uw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N9vy4f6aVVyOv0raB1LK7GyUtZGZYVL8KuARyOmpMMZCiQ5ydEKE4an1zI+2ztS4N9RyFFaBhImORDP9+fHVamdVtOLYp/DH8opt7zLZYj+QzE1dO+fDBts6bja1zdV8X/+3QGgWVFiRQXxbwjxJA2sgQcgsHi5GktmXOqpIvYzEcrh0Y8Pjbw69/cM9uVZA8hBzwPW1X1GsCPO/sjCfrNageRuYEGOw+XWOMOKanP4V0TC1tOOvlHOR5o5xhF2MR5NaSI42y00ouxq4fYVu2t+ZJgbzhs4kkE+5/nEZMrxuMiKguhiLsB6qd0BZ81zSAYnV+TgPy+rG06abzQfX3g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 12 Jan 2023 12:40:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.01.2023 13:08, Xenia Ragiadakou wrote:
> On 1/12/23 13:37, Jan Beulich wrote:
>> On 04.01.2023 09:44, Xenia Ragiadakou wrote:
>>> --- a/xen/arch/x86/include/asm/acpi.h
>>> +++ b/xen/arch/x86/include/asm/acpi.h
>>> @@ -140,8 +140,22 @@ extern u32 pmtmr_ioport;
>>> extern unsigned int pmtmr_width;
>>>
>>> void acpi_iommu_init(void);
>>> +
>>> +#ifdef CONFIG_INTEL_IOMMU
>>> int acpi_dmar_init(void);
>>> +void acpi_dmar_zap(void);
>>> +void acpi_dmar_reinstate(void);
>>> +#else
>>> +static inline int acpi_dmar_init(void) { return -ENODEV; }
>>> +static inline void acpi_dmar_zap(void) {}
>>> +static inline void acpi_dmar_reinstate(void) {}
>>> +#endif
>>
>> Leaving aside my request to drop that part of patch 3, you've kept
>> declarations for VT-d in the common header there. Which I consider
>> correct, knowing that VT-d was also used on IA-64 at the time. As
>> a result I would suppose movement might better be done in the other
>> direction here.
>
> I moved it to the x86-specific header because acpi_dmar_init() was
> declared there.
> I can move all of them to the common header.
I would prefer you doing so, yes, of course unless others object.
Jan
|
