[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH v4 01/14] xen/arm64: flushtlb: Reduce scope of barrier for local TLB flush


  • To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Henry Wang <Henry.Wang@xxxxxxx>
  • Date: Fri, 13 Jan 2023 11:36:26 +0000
  • Accept-language: zh-CN, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JwvPxYqJhARnyusAQLA8bWR4iDsYbq8TXKcUsQPOS0A=; b=mTdbmYCiHxQqFOUU87j6Aln6fGexFiG0zbAWnX3P3B09Xn8Lgy3/l03yNrPpCNSo/KlBzODnXegE5JNQ9c6I6xk9H8z8xO+zsg6UtZXNMzRaOjakT5oRoaNj87qonX9asauBl8C76B+JOYdviJps1Z4hVjpCgMo3HXPhgYb+a6g2FEtvRRVAWOeSNbfMEzKvLrSvxOR7y13cUGU/kdq5I8Uuiuw9oWVgXBzw2BU6oGFxI3Gj8+p9EN2DqPKAUJn444JKpx1Nk9dx+sXasywO35x9qHB0g3TdFYA9iWhD7reeqH+HVmV9hOPPg+vnsdW6ATbL5unSFUDpcutwcfyxXg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hawn/fzl3gqQ9w85h9x1MqJDJk9eEVUrStnjih6XTUU8WUK3e5JzkGx9IouyIXxxRfojI6T3uTCobHnKVPZXVPoYNshpcVsSPxE4NzjeCvqqFSPlcdfpvPaT2kvpwCfjNOr6mMqz/dfIwGrbM2zPdcZdcirlliLxMj2vkiv549o2LzSiEeXxOk/h4k7vZ8VlOmiSVbLXVmMcQ32FGQZE7UjRg1lxq8x4F2N39n//jxUGsgK0klbghuHL5XJsbBgCoHcb87Prc0NJ40l9NZjYCoqoWmuVwHD59c4Zm9s+Tf0L2kVcF2e0Uzfl+ZiKQVCTVFhSF12Ku7wvn0juxlyEiA==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Luca Fancellu <Luca.Fancellu@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
  • Delivery-date: Fri, 13 Jan 2023 11:36:49 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHZJzd9qGEAItqZ/Emo59lWSJotia6cNK4A
  • Thread-topic: [PATCH v4 01/14] xen/arm64: flushtlb: Reduce scope of barrier for local TLB flush

Hi Julien,

> -----Original Message-----
> Subject: [PATCH v4 01/14] xen/arm64: flushtlb: Reduce scope of barrier for
> local TLB flush
> 
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> Per D5-4929 in ARM DDI 0487H.a:
> "A DSB NSH is sufficient to ensure completion of TLB maintenance
>  instructions that apply to a single PE. A DSB ISH is sufficient to
>  ensure completion of TLB maintenance instructions that apply to PEs
>  in the same Inner Shareable domain.
> "
> 
> This means barrier after local TLB flushes could be reduced to
> non-shareable.
> 
> Note that the scope of the barrier in the workaround has not been
> changed because Linux v6.1-rc8 is also using 'ish' and I couldn't
> find anything in the Neoverse N1 suggesting that a 'nsh' would
> be sufficient.
> 
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

I've tested this patch on FVP. The dom0 boots fine, linux & zephyr
guests can be started and destroyed without issue, so:

Tested-by: Henry Wang <Henry.Wang@xxxxxxx>

Kind regards,
Henry


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.