[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN v4] xen/arm: Probe the load/entry point address of an uImage correctly


  • To: Dmytro Firsov <Dmytro_Firsov@xxxxxxxx>, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Ayan Kumar Halder <ayankuma@xxxxxxx>
  • Date: Fri, 13 Jan 2023 12:27:41 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rsqW6VEFQgcSxHB4O0hC9OpgzP3TyDZ46hREDKuHIuY=; b=WWf4fouXmaovKcSuDABGWj/BcGu5f4W29d37vSf+7ZQcOTsovzqOLzH8hRlOkGjOs8vjDozDHaiTI1G+kAhPUJMJ46bNz4ixx81YDrDKPNUtlc0LPzV/Uhs03xfhj0ddQLvikWDZBE9FwOkwCMbJWTcvj9f/Iqg0PlNBucVq1+DKwXma7GrzjwmA9uGUrWYtNUakNpPGF2Ct9AlYJXcvvxP736kh5PcLTQqqHBU1ZjJxrpZouGdrEco41+sjvaPqaIeqzDyHMyk1ThsSAuanfBbA9mvKa5zmUFHQdgZc1e3mjhjgfjW9iYsLzKkWcAF/cOq9LtpwZ9dUnJQbKVgjjA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dpFxG4jCr/SKmLuflJBR9stC570YowG1ZQoxv0txNJK2hbBgObxxFQMetCxkx0s8eFmhut1ojz0yTjFLDkPHdGGdrA8BUKLB/R2TiMt8M1hMwxNoePrM7OeI6V85tg6/S8SWJ6BPhsIa1LltGu/5B6GUBniUYvZ8g+n59UbNFhRGIB92tcn1oWf0oBmx32tBYh6aEWU5YeoofZ6jmw1F8vTb2CwL/EyaO00zernFQL363AlANuY9LnJEE8u6/kz0uyDe/FJbMgmiuyk++8+2BGRCQtdz2BolmelBDs2ix5okV79a8mEV5dz/ZEnOb3fD/34ytp2N5c/LYEcBIjbrKQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "stefano.stabellini@xxxxxxx" <stefano.stabellini@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>
  • Delivery-date: Fri, 13 Jan 2023 12:27:57 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi All,

On 10/01/2023 12:30, Dmytro Firsov wrote:
On 09.01.23 11:36, Oleksandr Tyshchenko wrote:

On 08.01.23 18:06, Julien Grall wrote:

Hello Julien, Ayan, all

Hi Ayan,
...
The changes look good to me (with a few of comments below). That
said, before acking the code, I would like an existing user of uImage
(maybe EPAM or Arm?) to confirm they are happy with the change.
I have just re-checked current patch in our typical Xen based
environment (no dom0less, Linux in Dom0) and didn't notice issues with
it. But we use zImage for Dom0's kernel, so kernel_uimage_probe() is
not called.


I CCed Dmytro Firsov who is playing with Zephyr in Dom0 and *might*
use uImage.
Hi Oleksandr, Julien, all

Current Xenutils/Zephyr Dom0 setup uses standard format for Zephyr on
arm64 which is zImage. Thus uImage changes will not affect me.

Many thanks for the confirmation.

I have addressed all of Julien's comments and sent out "[XEN v5] xen/arm: Probe the load/entry point address of an uImage correctly".

- Ayan





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.