Re: [PATCH v4 09/14] xen/arm32: head: Remove restriction where to load Xen

[Julien Grall <julien@xxxxxxx>]

Hi Luca,

On 13/01/2023 14:58, Luca Fancellu wrote:
> > +/*
> > + * Remove the temporary mapping of Xen starting at TEMPORARY_XEN_VIRT_START.
> > + *
> > + * Clobbers r0 - r1
> NIT: r0 - r3?
Yes. I have updated the version in my tree.

> > + */
> > +remove_temporary_mapping:
> > +        /* r2:r3 := invalid page-table entry */
> > +        mov   r2, #0
> > +        mov   r3, #0
> > +
> > +        adr_l r0, boot_pgtable
> > +        mov_w r1, TEMPORARY_XEN_VIRT_START
> > +        get_table_slot r1, r1, 1     /* r1 := first slot */
> > +        lsl   r1, r1, #3             /* r1 := first slot offset */
> > +        strd  r2, r3, [r0, r1]
> > +
> > +        flush_xen_tlb_local r0
> > +
> > +        mov  pc, lr
> > +ENDPROC(remove_temporary_mapping)
> > +
> The rest looks good to me, I’ve also built for arm64/32 and test this patch on 
> fvp aarch32 mode,
> booting Dom0 and creating/running/destroying some guests.
>
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Thanks!

Cheers,

--
Julien Grall