Re: [PATCH v4 13/14] xen/arm64: mm: Rework switch_ttbr()

[Julien Grall <julien@xxxxxxx>]

On 16/01/2023 09:23, Michal Orzel wrote:
> Hi Julien,
Hi Michal,

> On 13/01/2023 11:11, Julien Grall wrote:
> > diff --git a/xen/arch/arm/arm64/mm.c b/xen/arch/arm/arm64/mm.c
> > index 798ae93ad73c..2ede4e75ae33 100644
> > --- a/xen/arch/arm/arm64/mm.c
> > +++ b/xen/arch/arm/arm64/mm.c
> > @@ -120,6 +120,36 @@ void update_identity_mapping(bool enable)
> >       BUG_ON(rc);
> >   }
> >
> > +extern void switch_ttbr_id(uint64_t ttbr);
> > +
> > +typedef void (switch_ttbr_fn)(uint64_t ttbr);
> > +
> > +void __init switch_ttbr(uint64_t ttbr)
> > +{
> > +    vaddr_t id_addr = virt_to_maddr(switch_ttbr_id);
> Shouldn't id_addr be of type paddr_t?
No because...

> > +    switch_ttbr_fn *fn = (switch_ttbr_fn *)id_addr;
... here it will be used as a virtual address.

> > +    lpae_t pte;
> > +
> > +    /* Enable the identity mapping in the boot page tables */
> > +    update_identity_mapping(true);
> Could you please add an empty line here?
Sure.

Cheers,

--
Julien Grall