[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/17] xen/arm: implement helpers to get and update NUMA status
- To: Wei Chen <Wei.Chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 16 Jan 2023 14:02:08 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HPcv3kBseubSGIczE+gyQLRvkyIRxf4QdIzScOTg1hc=; b=K3/ROOFoMIE40kXmd0YFQidM2LkEhelIzsUYwyeqfdtZTUUzshBaRo0YasL5Enx2EYH+RvJI6QBVsX59WY5O9NjgVlnuk8WRFOsWhu9jhbxU14yeWq23VLVscDq8d1y3gmHJsb1P/xDJcs9CD5P51rqdPlKE5KMAxoEWqK9lAipUSpfyMIRaEo4JZJhNMtNpq19oidDlotj0VD3Su/lmnM1jZS+hCTP/zyYgRqCDssCFqnd3DZ/TmivW+YAquWcgiZGDj/LO5bibJjxa67+j3KABsXPhaY2307YW32SXcDmGgTpeUHNYNgM4v5jFgQ3aexd7Ag5XqIhpnrs1gEN/9g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CwqPCCa33SVGKelYnh8fHUWgyKdzXEvAeZ+1kBtBofycvGQ6gcNj6PNy/FSYUfUoJ8MHV8ajjpZNDUljbqhMDWQ+JovSBi6oQ1WuxlGfClAMBRQKmJc0DT5HtZFl7MbEQrZTPRk7L2EO7bS0WbOm57ngjrxOyMP2BsYL3KgfRIhh/5HuXxpuzReObnOD+E8no+oOdDghNEbNpYdkLGwiaeCfLZ/F/+ZR6l2vpWYVWFYKc9Zxfzs5tXP9YZXDxbwMwTZDb5PHFpNVFQ2+YFG9dBpA3TOw0yPoKPL/FrLWmYYEaRQjADq+/v7mRQlvbgVix+MkSipn0GsdpiLILv6GCA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: nd <nd@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 16 Jan 2023 13:02:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.01.2023 13:01, Wei Chen wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: 2023年1月16日 19:15
>>
>> On 16.01.2023 10:20, Wei Chen wrote:
>>> On 2023/1/12 16:08, Jan Beulich wrote:
>>>> On 12.01.2023 07:22, Wei Chen wrote:
>>>>>> -----Original Message-----
>>>>>> From: Jan Beulich <jbeulich@xxxxxxxx>
>>>>>> Sent: 2023年1月11日 0:38
>>>>>>
>>>>>> On 10.01.2023 09:49, Wei Chen wrote:
>>>>>>> --- a/xen/arch/arm/include/asm/numa.h
>>>>>>> +++ b/xen/arch/arm/include/asm/numa.h
>>>>>>> @@ -22,6 +22,12 @@ typedef u8 nodeid_t;
>>>>>>> */
>>>>>>> #define NR_NODE_MEMBLKS NR_MEM_BANKS
>>>>>>>
>>>>>>> +enum dt_numa_status {
>>>>>>> + DT_NUMA_INIT,
>>>>>>
>>>>>> I don't see any use of this. I also think the name isn't good, as
>> INIT
>>>>>> can be taken for "initializer" as well as "initialized". Suggesting
>> an
>>>>>> alternative would require knowing what the future plans with this are;
>>>>>> right now ...
>>>>>>
>>>>>
>>>>> static enum dt_numa_status __read_mostly device_tree_numa;
>>>>
>>>> There's no DT_NUMA_INIT here. You _imply_ it having a value of zero.
>>>>
>>>
>>> How about I assign device_tree_numa explicitly like:
>>> ... __read_mostly device_tree_numa = DT_NUMA_UNINIT;
>>
>> Well, yes, this is what I was asking for when mentioning the lack of use
>> of the enumerator. Irrespective of that I remain unhappy with the name,
>> though.
>>
>
> How about DT_NUMA_DEF or do you have some suggestions for the name?
Yeah, "DEFAULT" is probably the least bad one.
Jan
|
