Re: [PATCH v2 3/5] xen/version: Introduce non-truncating XENVER_* subops

[Julien Grall <julien@xxxxxxx>]

Hi,

On 16/01/2023 16:06, Jan Beulich wrote:
> > --- a/xen/include/public/version.h
> > +++ b/xen/include/public/version.h
> > @@ -19,12 +19,20 @@
> >   /* arg == NULL; returns major:minor (16:16). */
> >   #define XENVER_version      0
> >   
> > -/* arg == xen_extraversion_t. */
> > +/*
> > + * arg == xen_extraversion_t.
> > + *
> > + * This API/ABI is broken.  Use XENVER_extraversion2 instead.
> Personally I don't like these "broken" that you're adding. These interfaces
> simply are the way they are, with certain limitations. We also won't be
> able to remove the old variants (except in the new ABI), so telling people
> to avoid them provides us about nothing.
+1. This is inline with the comment that I made in v1.

Cheers,

--
Julien Grall