[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch V3 16/22] genirq/msi: Provide new domain id based interfaces for freeing interrupts
- To: David Woodhouse <dwmw2@xxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxx>
- From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- Date: Mon, 16 Jan 2023 20:22:07 +0100
- Cc: x86@xxxxxxxxxx, Joerg Roedel <joro@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>, Marc Zyngier <maz@xxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxxxx>, Dave Jiang <dave.jiang@xxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, Ashok Raj <ashok.raj@xxxxxxxxx>, Jon Mason <jdmason@xxxxxxxx>, Allen Hubbe <allenbh@xxxxxxxxx>
- Delivery-date: Mon, 16 Jan 2023 19:22:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
David!
On Mon, Jan 16 2023 at 18:58, David Woodhouse wrote:
> On Mon, 2023-01-16 at 19:11 +0100, Thomas Gleixner wrote:
>> + .flags = MSI_FLAG_FREE_MSI_DESCS |
>> MSI_FLAG_DEV_SYSFS,
>
> That doesn't apply on top of
> https://lore.kernel.org/all/4bffa69a949bfdc92c4a18e5a1c3cbb3b94a0d32.camel@xxxxxxxxxxxxx/
> and doesn't include the | MSI_FLAG_PCI_MSIX either.
Indeed. I saw that patch after my reply. :)
> With that remedied,
>
> Tested-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
>
> Albeit only under qemu with
> https://git.infradead.org/users/dwmw2/qemu.git/shortlog/refs/heads/xenfv
> and not under real Xen.
Five levels of emulation. What could possibly go wrong?
|