[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/6] tools: Switch to non-truncating XENVER_* ops


  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • From: Christian Lindig <christian.lindig@xxxxxxxxxx>
  • Date: Wed, 18 Jan 2023 13:34:12 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u78+sxLMkpAYLGfNYnZANoSWvbKSvwtyDW/fdKPu58c=; b=SVztvCyCuroBQxJPv0bgci9bPEoEmMNWw0kQVN7zA6Qb0gKHPPcd/ygOniEgi+LkljkVXUXH1Lj6Noxox66f/7dr0Nlvy9s9LL5bafVfIumMKE5JkmkazSTtO9ZXiio2+V2rNv1Ww6mXfH+1uXqn61uLWnwl5PWvWRuYfrJdLpOeGuVL8QWl79rehyXW/aFRcHXvtyCr/z2Zxio9cEiMziTxEJEYsuDJfNHElZl287nueTpKEFqO8NAF5SMfBOPBNw1n/KH+iikyjuhMVIVuiI83QE4R80GZzU9iOsBH871QFcE0ywuCqzlw8uyWDLzj8g21yym/RCHQ3XOHOs4SwA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZhFylaI8AejK5euE89GQyMAllujMB5wKVzYDgRBwSuvb3kD2uweJoIzNTf109Qc1xWpZR07oGJ5y4WDLwM14tSq948wqEaNhwpRyzL2NkMnqp1FN+J9oGxPybAzHzB9Vhj0KhMvYJy9sl/6FTTXIdRC4rR5iuDE45SkQHc4573TLc6a+ASRXeBiYhJXcXLLZlXPmCWHoAmLb0FWYj02YzQrrvI/YcYriq4nA36zoIAnk9i7m2gNqp0Zq2lpWQhrphcvP/5NRe6Zp+mRN1Q66m0v5eIdydiU8Rv3f6/bDm1A6LzlnHEfvSREbLlDohD+EPkee1DSuThYieUMcRyEIJg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>, Rob Hoes <Rob.Hoes@xxxxxxxxxx>
  • Delivery-date: Wed, 18 Jan 2023 13:34:28 +0000
  • Ironport-data: A9a23:ts3QdKzYxT9e+P48JIl6t+cKxyrEfRIJ4+MujC+fZmUNrF6WrkVUn WZKC2uOaPnZYzeket90atm+9BwBsJPczdc2T1M5ryAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UwHUMja4mtC5QRnPKAT4DcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KTl/9 /MXB2tdVzvA3+um/rfkcOpdptt2eaEHPKtH0p1h5RfwKK9/BLvkGuDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjaVlVMvuFTuGIO9ltiiTsVPn12Ep 2vAuWD4BB0bO/SUyCaf82LqjejK9c/+cNNJTeHkqqQx6LGV7m8fCjEWamnqmP+w23XvUIlxd B1JwzV7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OcpQRQ62 1nPmMnmbRRtv6eSUmm17aqPoHW5Pi19BWMLeyIsVwYO5Njn5oYpgXryos1LFae0ipj+Hmj2y jXT9Swm3exM04gMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl BA5dwK2toji0bnlePSxfdgw
  • Ironport-hdrordr: A9a23:VEokgKuH90Unk+jqyzJtgNGd7skDTNV00zEX/kB9WHVpm5qj5q eTdZMgpHzJYVcqOE3I9urqBEDtexnhHP1OgLX5X43MYOC8ghrNEGgK1+KL/9SHIUDDH4Vmu5 uIHZITNDVeZ2IK6/oTTGODYrQdKHjsytHMudvj
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHZKnsh9kQgU3QTvku0GVlWBss2ha6kKlQA
  • Thread-topic: [PATCH 0/6] tools: Switch to non-truncating XENVER_* ops

I will look at individual patches, too.

> On 17 Jan 2023, at 13:53, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> 
> This is the tools side of the Xen series posted previously.
> 
> With this, a Xen built with long strings can be retrieved:
> 
>  # xl info
>  ...
>  xen_version            : 4.18-unstable+REALLY LONG EXTRAVERSION
>  xen_changeset          : Tue Jan 3 19:27:17 2023 git:52d2da6c0544+REALLY 
> SUPER DUPER EXTRA MEGA LONG CHANGESET
>  ...
> 
> 
> Andrew Cooper (6):
>  tools/libxc: Move xc_version() out of xc_private.c into its own file
>  tools: Introduce a non-truncating xc_xenver_extraversion()
>  tools: Introduce a non-truncating xc_xenver_capabilities()
>  tools: Introduce a non-truncating xc_xenver_changeset()
>  tools: Introduce a non-truncating xc_xenver_cmdline()
>  tools: Introduce a xc_xenver_buildid() wrapper
> 
> tools/include/xenctrl.h             |  10 ++
> tools/libs/ctrl/Makefile.common     |   1 +
> tools/libs/ctrl/xc_private.c        |  66 ------------
> tools/libs/ctrl/xc_private.h        |   7 --
> tools/libs/ctrl/xc_version.c        | 206 ++++++++++++++++++++++++++++++++++++
> tools/libs/light/libxl.c            |  61 +----------
> tools/ocaml/libs/xc/xenctrl_stubs.c |  45 +++++---
> 7 files changed, 250 insertions(+), 146 deletions(-)
> create mode 100644 tools/libs/ctrl/xc_version.c
> 
> -- 
> 2.11.0
> 

Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.