Re: [PATCH v4 12/17] tools/xenstore: don't let hashtable_remove() return the removed value

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 18/01/2023 09:50, Juergen Gross wrote:
> Letting hashtable_remove() return the value of the removed element is
> not used anywhere in Xenstore, and it conflicts with a hashtable
> created specifying the HASHTABLE_FREE_VALUE flag.
>
> So just drop returning the value.
>
> This of course requires to free the value if the HASHTABLE_FREE_VALUE
> was specified, as otherwise it would be a memory leak.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall