[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/6] tools: Switch to non-truncating XENVER_* ops
- To: Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 20 Jan 2023 12:30:00 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RlNzqUkWLwuj4hAg9mEXT2f13j2mRSF9Xhc9eGvIHHM=; b=JGAlV2jmJ35N28PoMj/3M/Z6PzLqMzUAyAuAOKfGlS5SVkKpNFyzlhFahHfeQ9DGcwk6KPiDyWC32U2WbMubqdjCSAPpa0aTUFz5F470t2CcbMznK0tKy6nP9fYL1IGZ0T4cxRW2k3BzEsbDboGOW9Lm0r85nH6RqyhRoxMG4S/23UIQkaVimB3xkMRsPqi+wqEGeURTCnFQM1K+perj+TGTZoxaeYRjRWTIMlNPkdNEyjVT2N8gvg1XDr2fk5EInSEChDLv5smvXkTdfQYL6iDklRAQBUdqt7BsO8lwmoSaK8+GmJ1mQ8SJmJ7JUOhbAb0lkhTwUDKv51HXCQvOng==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=em+0yLlbBF2NM8a5U5AtaiZ5owkFk7S8S9IncGlwUTKmlBf0HQ9yj+t+W3BL7DwTS31bDqGSJTCI9PXychhvPlnhQoZX+iFK7F9fXaerzTgjpUBb9yKi63WKFZBxHjEhG00vNtUWDi4ujgw/52KpULje4YZ/7GEekezETTfhgA73Nzt5KhQ1nYXvFyLjgold28vbqPSs1krMfnDyk9xoAh0jc9NA6IhCHeYOpR4RSGwFFYDOjaJy3hMnX2rH1dxNlnP745OJ24LjfJ9x+KVTrIFksr1ENqTx8dPmVt/m3nQGTXMmReNnsqq4bhxSyS1CUJHIMaVVBuBF14qjOBqFkw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>, Rob Hoes <Rob.Hoes@xxxxxxxxxx>
- Delivery-date: Fri, 20 Jan 2023 12:30:40 +0000
- Ironport-data: A9a23:VYHKtaojkuRNmbYHg3EnYv2Tn1deBmIrZBIvgKrLsJaIsI4StFCzt garIBnVMv/eazake40kYNy3phxSsJ7QzNQ1SgRlqCs0E35B9ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weHzSFNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAG0BRR3TluGo+r3has5uuYMoLub6MrpK7xmMzRmBZRonabbqZv2WoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3j+OraYWLEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpra8w3AHCngT/DjUzXmK/hf+0i3WMZMhGc UUUoRop8YgLoRnDot7VGkfQTGS/lhwTQd1LCMUh9RqAjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+LqRuiNC5TKnUNDQcIRBUIy8Puq4YyilTIVNkLLUKuptj8GDW1x i/QqiE73+kXlZRSiPv9+k3biTWxoJSPVhQy+gjcQmOi6EV+eZKhYIurr1Pc6J6sMbqkc7VIh 1Bc8+D20QzEJc3lePClKAnVIIyU2g==
- Ironport-hdrordr: A9a23:KhTQaqi7YCZ7uUeWTDsOJ88+HHBQXt0ji2hC6mlwRA09TyX+ra 2TdZUguSMc7Qx6ZJhNo6HiBECrewK7yXcN2/h3AV7AZmjbUQmTQr2KhLGKqwEIfReOktK1vp 0QFpSWZueeMbErt63HDUCDYrQdKZ28kJyVuQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZKnshvDT8KCQSwEaQz5St3JRq4a6lR1+AgAH5fgA=
- Thread-topic: [PATCH 0/6] tools: Switch to non-truncating XENVER_* ops
On 19/01/2023 6:20 am, Juergen Gross wrote:
> On 17.01.23 14:53, Andrew Cooper wrote:
>> This is the tools side of the Xen series posted previously.
>>
>> With this, a Xen built with long strings can be retrieved:
>>
>> # xl info
>> ...
>> xen_version : 4.18-unstable+REALLY LONG EXTRAVERSION
>> xen_changeset : Tue Jan 3 19:27:17 2023
>> git:52d2da6c0544+REALLY SUPER DUPER EXTRA MEGA LONG CHANGESET
>> ...
>>
>>
>> Andrew Cooper (6):
>> tools/libxc: Move xc_version() out of xc_private.c into its own file
>> tools: Introduce a non-truncating xc_xenver_extraversion()
>> tools: Introduce a non-truncating xc_xenver_capabilities()
>> tools: Introduce a non-truncating xc_xenver_changeset()
>> tools: Introduce a non-truncating xc_xenver_cmdline()
>> tools: Introduce a xc_xenver_buildid() wrapper
>>
>> tools/include/xenctrl.h | 10 ++
>> tools/libs/ctrl/Makefile.common | 1 +
>> tools/libs/ctrl/xc_private.c | 66 ------------
>> tools/libs/ctrl/xc_private.h | 7 --
>> tools/libs/ctrl/xc_version.c | 206
>> ++++++++++++++++++++++++++++++++++++
>> tools/libs/light/libxl.c | 61 +----------
>> tools/ocaml/libs/xc/xenctrl_stubs.c | 45 +++++---
>> 7 files changed, 250 insertions(+), 146 deletions(-)
>> create mode 100644 tools/libs/ctrl/xc_version.c
>>
>
> Hmm, I'm not completely opposed to this, but do we really need all that
> additional code?
>
> Apart from the build-id all the information is easily available via hypfs.
capabilitiles at the very least isn't there. Not that I'm particularly
complaining - its not an interface we want to encourage.
> And the build-id can be easily added to hypfs.
Hypfs is optional, and you will find firm resistance to making it
mandatory for this.
Also, having looked at how hypfs_string_set_reference() works, it's not
correct with livepatching (nothing updates size). I suspect this only
impacts the livepatching "unit" tests which nothing runs (hence why
livepatching is *still* broken on 4.15 and later).
~Andrew
|
