[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 03/14] xen/riscv: add <asm/riscv_encoding.h header
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 23 Jan 2023 15:06:58 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P21u4ASxTbtBeOJs2lFm4pkVDbXGeEzJ9di5SWW6JF8=; b=REviq/hnQFkzgF2C1CMasa/1xIsLS+Z11sjwJVtrTkbUBQZk/Oj71QJF8TDPU3B5uUxxLafF7OOGgSgFjQbW/ffzPtE7aqzaBc1JoeW+IGW1gzORtouF60llHIs+rBtyZLYBm2FljUEpS0vqT0QTigQwpgtj/ZT/2S+wm2QW7CiI75EiIfQ+leSaMNXberx31u0pPuflGCH01apQ0wAeIi+1wcWXqRdcbyA5RXFrVJFbmNkVKfghj8FiygziUtdRH5YwYo4m86JNbvNQygUG6F1W279NYJaxxYJx/tN9C+xcp0bYDXhTutbNtmca7NOhNM4UZRr4RsIrw4nGxmxMhg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J//sUL94lXPcYupt8OCY4F7TdsCz8zcsIXflLKdDvQlWPIFm9X/cVeBMKBu5jPZhTyGfsQBRQLtR/HnU/lRBKZMLubdnqNzZ7qgIPlSdoj2wUZHHmj9JgJra416O55STooyjaWu2vdoEsvq7H11FwaHOkJqmSx2KyH9m6yD1GE0UdgL1DFpA1QNj0lgCIekIA6RuK5gvW/rtVknCBO6G+EJc2cZvwOAgit+6nFi1q6/Q4jDBdG+ljhIvw65bWnqNd9RZlcuwGFrofif6sbaXRqyWGm99pkjYkxZ9Bcwv+b0kVq4ZXPlcV824QJhu0TMz1AXhUbB1xjj2r1g1tj2prw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 23 Jan 2023 14:07:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.01.2023 15:04, Oleksii wrote:
> On Mon, 2023-01-23 at 14:52 +0100, Jan Beulich wrote:
>> On 20.01.2023 15:59, Oleksii Kurochko wrote:
>>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
>>
>> I was about to commit this, but ...
>>
>>> --- /dev/null
>>> +++ b/xen/arch/riscv/include/asm/riscv_encoding.h
>>> @@ -0,0 +1,945 @@
>>> +/* SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) */
>>> +/*
>>> + * Copyright (c) 2019 Western Digital Corporation or its
>>> affiliates.
>>> + *
>>> + * Authors:
>>> + * Anup Patel <anup.patel@xxxxxxx>
>>
>> ... this raises a patch authorship question: Are you missing her/his
>> S-o-b: and/or From:?
>>
> It is not clear who should be in S-o-b and/or From. So let me explain
> situation:
>
> Anup Patel <anup.patel@xxxxxxx> is a person who introduced
> riscv_encoding.h in OpenSBI.
>
> A person who introduced the header to Xen isn't clear as I see 3 people
> who did it:
> - Bobby Eshleman <bobbyeshleman@xxxxxxxxx>
> - Alistair Francis <alistair.francis@xxxxxxx>
> - One more person whoose last name, unfortunately, I can't find
> And in all cases I saw that an author is different.
Then maybe simply move the "Author:" part into ...
>>> + * The source has been largely adapted from OpenSBI:
>>> + * include/sbi/riscv_encodnig.h
... this sentence, e.g. by appending "originally authored by ..."?
Jan
|
