|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [XEN v4 2/3] xen/drivers: ns16550: Fix the use of simple_strtoul() for extracting u64
One should be using simple_strtoull() ( instead of simple_strtoul() )
to assign value to 'u64' variable. The reason being u64 can be
represented by 'unsigned long long' on all the platforms (ie Arm32,
Arm64 and x86).
Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
---
Changes from -
v1, v2 - NA (New patch introduced in v3).
v3 - Added Suggested-by and Reviewed-by tags.
xen/drivers/char/ns16550.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
index 58d0ccd889..43e1f971ab 100644
--- a/xen/drivers/char/ns16550.c
+++ b/xen/drivers/char/ns16550.c
@@ -1532,7 +1532,7 @@ static bool __init parse_positional(struct ns16550 *uart,
char **str)
else
#endif
{
- uart->io_base = simple_strtoul(conf, &conf, 0);
+ uart->io_base = simple_strtoull(conf, &conf, 0);
}
}
@@ -1603,7 +1603,7 @@ static bool __init parse_namevalue_pairs(char *str,
struct ns16550 *uart)
"Can't use io_base with dev=pci or dev=amt options\n");
break;
}
- uart->io_base = simple_strtoul(param_value, NULL, 0);
+ uart->io_base = simple_strtoull(param_value, NULL, 0);
break;
case irq:
--
2.17.1
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |