[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 3/5] x86/iommu: call pi_update_irte through an hvm_function callback


  • To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 24 Jan 2023 17:08:07 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sNwknKSSwotwLR5xCl2QxXrTihZFnHtv9H4h8RfW9b0=; b=FPMoTMcoBSYWBztYlIjOXcN7mJHEHVIf98Kq2xfQWZcKyxsnU1df/zwAQJAjFA3/wVzdaeTlEwpRL7pTjQvAKELwrW0afOC5onq/mpvk1jSo8uUrrFV64AUeSFtiAqAHaI7TdVjQoFHceehqmYm8qXp7XKNNzoUKdBhI8I8aAXKeeV92Vrt9p/KwKO75gurubz/OgP9M7pQjX02asJb7w+uthoKLzUDNnA43F3TMdoHbzBzkm2VsdNgnVxqFxgXQgSCUA97ZvCCAlUOrwFY8lowHJx6LIKFrDuoSTy2lRODHSNQI4eEkMgN5y2iLfcYkM4T2tpraoZsUcXQWipa0JQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AWks2c5qtXQ74PBPZkVspG150flSTyUbK45duJIq2Un9fSDkVsoYRjrNHjT3oz/kqHaMvLusJMHbWoSQ/N+L/nMQ/GSw2MdvIK60D0TMWwMPYNyVMfGCSFmArSYOnr+d/ro8ciufVblBAzsjRrTX2GS1f6PDyV19ZbQ/n6uZGOD0Yxubn2vkd7MwVkUE0B5dWzHZDKIyZehw7nLNe58h8lEdR1g1W8nTe3GtSUScRaxyzuZ0DaSGE5OqEtZsL5Mqbr8nRLGcQPmr5sezp6yS4MDvvv+7wf/A23Gu7v4FGpazkv9DD99gwgP1XcfJxPMH9n+yOXm9w8V3w8NgRPHj3Q==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 24 Jan 2023 16:08:19 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.01.2023 13:41, Xenia Ragiadakou wrote:
> Posted interrupt support in Xen is currently implemented only for the
> Intel platforms. Instead of calling directly pi_update_irte() from the
> common hvm code, add a pi_update_irte callback to the hvm_function_table.
> Then, create a wrapper function hvm_pi_update_irte() to be used by the
> common hvm code.
> 
> In the pi_update_irte callback prototype, pass the vcpu as first parameter
> instead of the posted-interrupt descriptor that is platform specific, and
> remove the const qualifier from the parameter gvec since it is not needed
> and because it does not compile with the alternative code patching in use.
> 
> Since the posted interrupt descriptor is Intel VT-x specific while
> msi_msg_write_remap_rte is iommu specific, open code pi_update_irte() inside
> vmx_pi_update_irte() but replace msi_msg_write_remap_rte() with generic
> iommu_update_ire_from_msi(). That way vmx_pi_update_irte() is not bound to
> Intel VT-d anymore.
> 
> Remove the now unused pi_update_irte() implementation.
> 
> No functional change intended.
> 
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.