[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/x86: public: add TSC defines for cpuid leaf 4
- To: Krister Johansen <kjlx@xxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 25 Jan 2023 07:57:16 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LMGxywd3OXSdXfdzAAZ9ttYRe4lHqqnocHfh7aGa3FI=; b=Y+ZBx0UQuG54rtKBtjJuQj1YjoB4wGocyKvuEBZmapgI33sjvp8fhOX5Nn9fG76bqMAtUIRzQTCznw7fzaBSPpkX9s9FKW/UzAdQpOnep1iGJ6ATW71k++UrLhDQ1arFSkn8x/vfJrSzbXTT0Y45FjbVcGcfbVQWgnCSCongsk1kymQvtnQgkSZ3OCJvm8sYxJ44jWR25o5sn7vH+GnA8dloM1BSFob5BiLfO86FP2K2JXeKJGhgsshma/Ytg5DY0zDdToQsBrFjtFOOVDaxpWzatwYLVvvSXnMtnDZG4eIquMPRdqnIpK7UFScJrUMU1QZlLamf2jigAV71/Or/bA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GusuMdDprl11HR7Wfd2TxM/tQvacf/s/VBiIOSDeBztnfR7o3CHdYy9xHB/bv50qW42Iv/r/BQMQwqNapCLeOp7M8lnLGgnxeFtwJ4ASSZ5IuNqMtEm9ZkkmqSLb7MrEXbKhJK89IvS2LoUz/JAFs/RqKNpbB6uFvQHTO/eErJbYKYRWnjpkegfdz5dYGSPofc1nKwCbWW19PlkvTMY6Gzq8bDaNLjBoMCanIBxMvgjLR0na0PD2utnv8Pi5q/FQNhWRpUqsPPaTvEEw4r8pceZ4IOeWNVls/T/Jcb4dBnn3FuYSh2XxPB2mVRRMAh69vj6rkOEgd3iHgtm5AgRYfw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, David Reaver <me@xxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 25 Jan 2023 06:57:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.01.2023 23:35, Krister Johansen wrote:
> --- a/xen/include/public/arch-x86/cpuid.h
> +++ b/xen/include/public/arch-x86/cpuid.h
> @@ -71,6 +71,12 @@
> * EDX: shift amount for tsc->ns conversion
> * Sub-leaf 2: EAX: host tsc frequency in kHz
> */
> +#define XEN_CPUID_TSC_EMULATED (1u << 0)
> +#define XEN_CPUID_HOST_TSC_RELIABLE (1u << 1)
> +#define XEN_CPUID_RDTSCP_INSTR_AVAIL (1u << 2)
> +#define XEN_CPUID_TSC_MODE_DEFAULT (0)
> +#define XEN_CPUID_TSC_MODE_EMULATE (1u)
> +#define XEN_CPUID_TSC_MODE_NOEMULATE (2u)
This could do with a blank line between the two groups. You're also
missing mode 3. Plus, as a formal remark, please follow patch
submission rules: They are sent To: the list, with maintainers on
Cc:.
Jan
|
