[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/3] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded
- To: Alexander Bulekov <alxndr@xxxxxx>
- From: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
- Date: Wed, 25 Jan 2023 17:19:49 -0500
- Cc: qemu-devel@xxxxxxxxxx, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Mauro Matteo Cascella <mcascell@xxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, Laurent Vivier <lvivier@xxxxxxxxxx>, Bandan Das <bsd@xxxxxxxxxx>, "Edgar E . Iglesias" <edgar.iglesias@xxxxxxxxx>, Darren Kenny <darren.kenny@xxxxxxxxxx>, Bin Meng <bin.meng@xxxxxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, "Michael S . Tsirkin" <mst@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Daniel P . Berrangé <berrange@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, Jon Maloy <jmaloy@xxxxxxxxxx>, Siqi Chen <coc.cyqh@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Hanna Reitz <hreitz@xxxxxxxxxx>, Amit Shah <amit@xxxxxxxxxx>, Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Peter Maydell <peter.maydell@xxxxxxxxxx>, Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Klaus Jensen <its@xxxxxxxxxxxxx>, Fam Zheng <fam@xxxxxxxxxx>, Dmitry Fleytman <dmitry.fleytman@xxxxxxxxx>, "Gonglei (Arei)" <arei.gonglei@xxxxxxxxxx>, "open list:X86 Xen CPUs" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "open list:virtio-blk" <qemu-block@xxxxxxxxxx>, "open list:i.MX31 (kzm)" <qemu-arm@xxxxxxxxxx>, "open list:Old World (g3beige)" <qemu-ppc@xxxxxxxxxx>
- Delivery-date: Wed, 25 Jan 2023 22:20:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jan 19, 2023 at 02:03:08AM -0500, Alexander Bulekov wrote:
> This protects devices from bh->mmio reentrancy issues.
>
> Signed-off-by: Alexander Bulekov <alxndr@xxxxxx>
> ---
> hw/9pfs/xen-9p-backend.c | 4 +++-
> hw/block/dataplane/virtio-blk.c | 3 ++-
> hw/block/dataplane/xen-block.c | 5 +++--
> hw/block/virtio-blk.c | 5 +++--
> hw/char/virtio-serial-bus.c | 3 ++-
> hw/display/qxl.c | 9 ++++++---
> hw/display/virtio-gpu.c | 6 ++++--
> hw/ide/ahci.c | 3 ++-
> hw/ide/core.c | 3 ++-
> hw/misc/imx_rngc.c | 6 ++++--
> hw/misc/macio/mac_dbdma.c | 2 +-
> hw/net/virtio-net.c | 3 ++-
> hw/nvme/ctrl.c | 6 ++++--
> hw/scsi/mptsas.c | 3 ++-
> hw/scsi/scsi-bus.c | 3 ++-
> hw/scsi/vmw_pvscsi.c | 3 ++-
> hw/usb/dev-uas.c | 3 ++-
> hw/usb/hcd-dwc2.c | 3 ++-
> hw/usb/hcd-ehci.c | 3 ++-
> hw/usb/hcd-uhci.c | 2 +-
> hw/usb/host-libusb.c | 6 ++++--
> hw/usb/redirect.c | 6 ++++--
> hw/usb/xen-usb.c | 3 ++-
> hw/virtio/virtio-balloon.c | 5 +++--
> hw/virtio/virtio-crypto.c | 3 ++-
> 25 files changed, 66 insertions(+), 35 deletions(-)
Should scripts/checkpatch.pl complain when qemu_bh_new() or aio_bh_new()
are called from hw/? Adding a check is important so new instances cannot
be added accidentally in the future.
Stefan
Attachment:
signature.asc
Description: PGP signature
|
