[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 04/11] xen: extend domctl interface for cache coloring
- To: Carlo Nonato <carlo.nonato@xxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 26 Jan 2023 08:25:21 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=maygO8TCv17GMyYbpi2QfNkyPw39ruWhUXIBMdNPS8w=; b=lrewr8mNaelIeyQl1P2HN++6phG5MfHWKVJnr8MCe3CgiZPnrBIfMUMK89chDQ9JMNAYM/lFCOULWf2ZBckaBWzJcMhsNaB9DUQKbSTbM15ChlEJmaEOVX1tIvexm0Sd0tvieI3Y3oCXpUmqIYNHGe0HLdKBA4js57IqA+UB1BP5lhfkJICr3Y+NI0OYH0DyWNFHFfEKrKzRu6iNNklAS8TKZteewcF2deD8pHdNWkrJgQB2ljbTQeRt8856EuWe12NHRTau76OWltRaAMLruScNrZGopfephd1rMTozhuHnCsfqXp/4bexDeUuJ0JXsN0xI4cvkidgM3HxdO2Pb1A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cTipI0aJrfne+AgNwoQWsi0QbbBGD1Ehwevpi0hk6vWNkK6BVfsgXZ8zvEbXz+CqEquaM64k6n0Ar43nL3u33/eaRoRPi5UspTE7xnbHOiGHgPSTDEq4B2SRfxGbmKQvn6uIAw9TaoOIFXiYAKcxPc/Z1K4SqzS1D8lV2HLPySH+j6TVpkwfrCVloUR99EpMma3zR4V7gMAuikioqJZQfx18DUK3tM5Wonh5hOddW4xSPHUQGVOBZhHwPVEAgdJTpQoHkdo3Dj9bFIGQ+N1d0WTnN6D+ud/ZH+Lp9SSGA4mRlPaO9KdsRewuR3woWgdLIO2NJPCpymMaFwlKiTHT6g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marco Solieri <marco.solieri@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 26 Jan 2023 07:26:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.01.2023 17:29, Jan Beulich wrote:
> On 23.01.2023 16:47, Carlo Nonato wrote:
>> @@ -92,6 +92,10 @@ struct xen_domctl_createdomain {
>> /* CPU pool to use; specify 0 or a specific existing pool */
>> uint32_t cpupool_id;
>>
>> + /* IN LLC coloring parameters */
>> + uint32_t num_llc_colors;
>> + XEN_GUEST_HANDLE(uint32) llc_colors;
>
> Despite your earlier replies I continue to be unconvinced that this
> is information which needs to be available right at domain_create.
> Without that you'd also get away without the sufficiently odd
> domain_create_llc_colored(). (Odd because: Think of two or three
> more extended features appearing, all of which want a special cased
> domain_create().)
And perhaps the real question is: Why do the two items need passing
to a special variant of domain_create() in the first place? The
necessary information already is passed to the normal function via
struct xen_domctl_createdomain. All it would take is to read the
array from guest space later, when struct domain was already
allocated and is hence available for storing the pointer. (Passing
the count separately is redundant in any event.)
Jan
|
