[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xen/x86: public: add TSC defines for cpuid leaf 4
- To: Krister Johansen <kjlx@xxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 26 Jan 2023 09:57:43 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MW1uAeyzIXYgFzZDoCTqIsfkigZzerbTXM+ilyurhaU=; b=XFhW95+a+saJr91ZntAhk0Yp6Q8OmTRI9doD0IcYmZ+C+3NjViaOXgBrVSVSqfTkymiIowPb28jF4jI8wVhxnoXBPhsQAnq+oznCmsyhAPOwHh4/s8G3BQp/Osv/9JY1/A0FNxr7TqLk1oD075biYsHsyETS4CJQ4J1wjzsoKy6JInSOwuMEhXfCY5YKjJs4sPOeRq4Mm/RwUk+eEi77ZG6gKN9Pe2c4oSxxrPUJn4CiAsjOQHr3jl4fSUbTjRHrTYXEndmFzVTLXW6HURfWgEIBqGXgm4cKWEAFYE9SG/mc6yVJWOR/OIVuZSuH0T0NqnM+tIFE7ov2/3F8zyriJA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SS6inCbMqnb84+xIQpueDSHR/V0jb+47VoliqhOzyzLlbCeQg1FOBcbvlZqY0aqK1+KVrTtP49LQAhXf2wPeLzc1GsO09odbpWoiGCA+1YKbX6he0ZGjY3WLD9cLyK5iEuc+2T3zcU36/bRjsfcjC6KlPQ7ekl9A02Q8AvOVxEi6ESg8AA6jvJUATwpMcVGP0rCs0Q+dOKYYUSI15oPUzar/861EshyDML8a8L3sA3HspWGjsp169H713ys0zVy6eIT2vio8A8ZPwf0JmaK10RprBvIdibAFt1u7nH+DZ7ZvF8opCj8bo0nnqTB3W1bqfhVsvsw38guFTxcw3gbX7w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, David Reaver <me@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 26 Jan 2023 08:58:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.01.2023 19:45, Krister Johansen wrote:
> v2:
> - Fix whitespace between comment and #defines (feedback from Jan Beulich)
Hmm, ...
> --- a/xen/include/public/arch-x86/cpuid.h
> +++ b/xen/include/public/arch-x86/cpuid.h
> @@ -72,6 +72,14 @@
> * Sub-leaf 2: EAX: host tsc frequency in kHz
> */
>
> +#define XEN_CPUID_TSC_EMULATED (1u << 0)
> +#define XEN_CPUID_HOST_TSC_RELIABLE (1u << 1)
> +#define XEN_CPUID_RDTSCP_INSTR_AVAIL (1u << 2)
> +#define XEN_CPUID_TSC_MODE_DEFAULT (0)
> +#define XEN_CPUID_TSC_MODE_EMULATE (1u)
> +#define XEN_CPUID_TSC_MODE_NOEMULATE (2u)
> +#define XEN_CPUID_TSC_MODE_NOEMULATE_TSC_AUX (3u)
... while I'm fine with the leading blank line, what my earlier comment was
about really are the two separate blocks of #define-s (the flag bits and the
modes). I'll take care of this while committing; with the adjustment
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
