[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/python: change 's#' size type for Python >= 3.10


  • To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 26 Jan 2023 10:14:54 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M3y46onS+R+2h2xkxHtZmw8U0u00amcjJQwPunPuj5Y=; b=UMMl0YiefOXnrku8QgJHLFVntBy9eZp3gWBsvXzAh6rPUXaZgYUeHxTbwZQOITYbxkHI0TCyg9Zfw0TdICF6aN8JLiMT8D0KZbWd6RQ+TpaKrz9b2MhAyuguSzphCGlNTjZ+qgRKTWuEnlJbpKErFY7fX6TIbbKuRfxZ4/8TUG0Syw8ab/WLBGFPa5sNw5v2WSCWYyRd6hA5oDmtBjsXCxYHrG4kGhExF0OTJSyPL1RK+J/NZW4TvQIkR1sGZCoVJNrqOjV/I28FYOluH4CNPTsrfGDxPt3+qQEePc69rReBIk+Yw48DPBskoCqZPQSLq356E3Bt9FSSz4V9Kp/AVg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HUkRYXfjCWdFAWWENBlBK42ErIP1HCzUv/luReeTVIkMZmq9hBEKlPwIjvNovJzSpZU4DIesLpemiHvm6PWvhZtAM+2E2B8+EytEBMXeaTCRuu+tqpv5Wpfw1CiTa4M5aTvXn2AWylrClu13uMb/g4icP7XSMJMX6lD0kRGq8xuHaUieKh7G9aA/AYJI2QAryNK7rqV8/fJw2tFMEOlrnVnm4i0tIhTAGfORzc/HLt25EX/JHVrjMVpLILyjSVEV6UAxZFfBvtobXICoH8FUws0DViXQ4Ad0SGz6/DUc5G+srVrw3un4hlKfiv+Hti+vxHo3Jz4G4Np6O8IRvlEzwg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 26 Jan 2023 09:15:21 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26.01.2023 06:13, Marek Marczykowski-Górecki wrote:
> @@ -1774,7 +1775,7 @@ static PyObject *pyflask_load(PyObject *self, PyObject 
> *args, PyObject *kwds)
>  {
>      xc_interface *xc_handle;
>      char *policy;
> -    uint32_t len;
> +    Py_ssize_t len;

I find this suspicious - by the name, this is a signed type when an
unsigned one was used here before (and properly, imo).

Irrespective of the remark of course I'll leave acking (or not) of this
to people knowing Python better than I do.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.