Re: [PATCH v2] tools/helpers: don't log errors when trying to load PVH xenstore-stubdom

[Juergen Gross <jgross@xxxxxxxx>]

On 27.01.23 08:40, Jan Beulich wrote:
> On 27.01.2023 06:54, Juergen Gross wrote:
> > When loading a Xenstore stubdom the loader doesn't know whether the
> > lo be loaded kernel is a PVH or a PV one. So it tries to load it as
> > a PVH one first, and if this fails it is loading it as a PV kernel.
> >
> > This results in errors being logged in case the stubdom is a PV kernel.
> >
> > Suppress those errors by setting the minimum logging level to
> > "critical" while trying to load the kernel as PVH.
> >
> > Fixes: f89955449c5a ("tools/init-xenstore-domain: support xenstore pvh stubdom")
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > ---
> > V2:
> > - retry PVH loading with logging if PV fails, too (Jan Beulich)
> I'm sorry to be picky, but shouldn't this be reflected in the description?
I can add that, but I think looking at the patch itself it is rather
clear, especially with the added comments.

If you still think it should be added, my suggestion would be:

  In case PVH mode and PV mode loading fails, retry PVH mode loading
  without changing the log level in order to get the error messages
  logged.

I can resend, if you want me to, or I'd be fine with above addition
added while committing (if needed).


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature