[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 14/14] automation: add smoke test to verify macros from bug.h
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Fri, 27 Jan 2023 15:43:36 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q7ge0+vYmN+Gld9693vJ9njAWboUUQHvcT6vUQfNbgo=; b=FS8N/ukHWjNUUL2uNjm8cjem6qIF9sS9s/Dz5bMoR1gc++P+Mhc57Vgq4FmgAvCa8A2M6WDuLxGTsExWw33LsseQ2TFEZe2qAiLTdiWeNTKmoiDoazcfvQ6i7x73gVKL0YLgHv8YnUIhb9+B5Z3iF9Qb7fSOgIVUgfX8+4Z5gHanja7dGGKfWLhM3t3RVOyuL9yi19Mv9Z44pyPT+CfFn6RtfC6YvO7UN0lBjDitSKMUnTqvoTrMqM05INogSrNtZkmLqic1w7N5zGgW+xoqaYIw/4EaVdqrc09O+scZ/5ixa64BbAx4WHtr7ZspToSe9ZrvoKAFqq9fFVSnfZj6YQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lpUW46YQGXG3tIRT9kvgnue4WJqubBAG4+fe0TlIu/xU70zXCAaRMM//Ab7jAnczrzjr6H2OKhtBVYUJNq5JHyll8mLQl+eMKaZkMr7zzxXSkLJTDq6m6905kDQsR19iTMqjaK2ellbTKl3/PwbYFUY4Nv9m4AItwQnsH5uOL1j8vEahX9TW1vtwyHhwCJDOppG9rY3wxjR3CB2pVv/udSYq+9krLKhdp4JZOHxiKR3T/D5gjf1tFj5VP3mF6arI+/41VEkdv1pH24hFCBNWUlfyWgJUnw65Dfx4zVF2yr/zSZ9cqxqz3xY5Y3bt505e4bL7INgt9VSA1zHbHEa/LA==
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>
- Delivery-date: Fri, 27 Jan 2023 14:43:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Oleksii,
On 27/01/2023 14:59, Oleksii Kurochko wrote:
>
>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> ---
> Changes in V2:
> - Leave only the latest "grep ..."
> ---
> automation/scripts/qemu-smoke-riscv64.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/automation/scripts/qemu-smoke-riscv64.sh
> b/automation/scripts/qemu-smoke-riscv64.sh
> index e0f06360bc..02fc66be03 100755
> --- a/automation/scripts/qemu-smoke-riscv64.sh
> +++ b/automation/scripts/qemu-smoke-riscv64.sh
> @@ -16,5 +16,5 @@ qemu-system-riscv64 \
> |& tee smoke.serial
>
> set -e
> -(grep -q "Hello from C env" smoke.serial) || exit 1
> +(grep -q "WARN is most likely working" smoke.serial) || exit 1
I think the commit msg is a bit misleading and should be changed.
FWICS, you are not *adding* any smoke test but instead modifying
the grep pattern to reflect the usage of WARN.
> exit 0
> --
> 2.39.0
>
>
~Michal
|
